From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60407: [PATCH] Update go-ts-mode to use Imenu facility Date: Sun, 08 Jan 2023 12:59:14 +0200 Message-ID: <83a62tqol9.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10548"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dev@rjt.dev, casouri@gmail.com, 60407@debbugs.gnu.org To: Evgeni Kolev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 08 11:59:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pETOS-0002U7-Ie for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Jan 2023 11:59:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pETOK-0005ko-DQ; Sun, 08 Jan 2023 05:59:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pETOJ-0005kd-8X for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2023 05:59:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pETOI-0007AW-R4 for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2023 05:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pETOI-0004Ar-Ga for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2023 05:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Jan 2023 10:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60407 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60407-submit@debbugs.gnu.org id=B60407.167317553816034 (code B ref 60407); Sun, 08 Jan 2023 10:59:02 +0000 Original-Received: (at 60407) by debbugs.gnu.org; 8 Jan 2023 10:58:58 +0000 Original-Received: from localhost ([127.0.0.1]:60006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pETOE-0004AY-Gh for submit@debbugs.gnu.org; Sun, 08 Jan 2023 05:58:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pETOD-0004AJ-C9 for 60407@debbugs.gnu.org; Sun, 08 Jan 2023 05:58:57 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pETO8-000795-1W; Sun, 08 Jan 2023 05:58:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=T22wLaiuVuVURn715qmAOkliseBAB6jLh0pwJ+ArIq0=; b=EKEwciCVfHoT bW6uuBd8t69tjqmNsgYRQRtbGw8mSw8wM/RXVRayEEXmwcy/ZNFLECN2TwqlnNmoVGoVxrKBq2ifC iCShqrT4KlF9Rh6YghYm6VHcRWbrThNpKS0fNgfwTg4bWmDCSL3Lg54lF5NXmbk14wa+IZ7WX7t4Y JhrS/rYS/vTwyiKlu2CdDlzwi+qzTaaO6qCJFZIorxCwCXm2bWl2mirNm3orLfDK9P+RfJ3WWzc2H j3JJA/df+QIJJcm6nN+wextc0hDCCDq7KkWDjF+TfKfjus8nOvsZllQXPtDAok/uTBxLkV3r+mb5k igg2gJmUBTFLoG7z/W3tzg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pETO7-0001dy-Ha; Sun, 08 Jan 2023 05:58:51 -0500 In-Reply-To: (message from Evgeni Kolev on Sun, 8 Jan 2023 10:10:33 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252907 Archived-At: > From: Evgeni Kolev > Date: Sun, 8 Jan 2023 10:10:33 +0200 > Cc: Randy Taylor , Eli Zaretskii , 60407@debbugs.gnu.org > > A side question - does it make sense to extend go-ts-mode with > interactive functions? > > For example a function (go-ts-mode-docstring) which adds a docstring > for the current type: > with Go code: > func sum(a, b int) int {...} > the function would add a comment above the func: > // sum > func sum(a, b int) int {...} > > This is something I've implemented for myself, I'm wondering if it > makes sense to contribute it to go-ts-mode. It makes sense, but it will have to wait until Emacs 30. The release branch is frozen, and no new features are accepted. > Or should I first discuss this in the devel mail list? Or maybe send > another patch and have the discussion there? Either one would be good. Thanks.