From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser Date: Mon, 06 Feb 2023 15:19:23 +0200 Message-ID: <83a61rq6ck.fsf@gnu.org> References: <83edr3q8ez.fsf@gnu.org> <87o7q7dl4o.fsf@masteringemacs.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20479"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, 61235@debbugs.gnu.org To: Mickey Petersen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 06 14:21:05 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pP1Qf-00059Y-2a for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Feb 2023 14:21:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pP1QM-0008Uv-8d; Mon, 06 Feb 2023 08:20:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP1Pf-0008Co-2F for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2023 08:20:11 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pP1Pe-0001NM-OJ for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2023 08:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pP1Pe-0007Ng-6w for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2023 08:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Feb 2023 13:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61235 X-GNU-PR-Package: emacs Original-Received: via spool by 61235-submit@debbugs.gnu.org id=B61235.167568956028303 (code B ref 61235); Mon, 06 Feb 2023 13:20:02 +0000 Original-Received: (at 61235) by debbugs.gnu.org; 6 Feb 2023 13:19:20 +0000 Original-Received: from localhost ([127.0.0.1]:47584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP1Oy-0007MR-AA for submit@debbugs.gnu.org; Mon, 06 Feb 2023 08:19:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP1Ow-0007MD-Fk for 61235@debbugs.gnu.org; Mon, 06 Feb 2023 08:19:19 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP1Oq-0001Ey-P0; Mon, 06 Feb 2023 08:19:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=A3CMFxxNNmW72zj5b+Ncj1LfI98EhNoMAPwjDQgh1nA=; b=Q6KY17zcuG1p MS77ecpccMq4qQ54FNpZEM1H+4Dba1LiMk760vVNk6+Jk+KHyNV8mG02QA5gesrlJLebtOO2MaGzW vkaCQiXstYfe2CGoYIzqih1oe8c32pFf5N2+DgPaL0APrr3C34WSN7KKhqXDosgV54Khqi5yS2/8S 0hS9EvgvBNjvMlJEPSx+A6F/4ZD3UNMC1vKmBPsoaDF8OEacE2CGKIexwJEbhwCXNkmVAGzzM9SHh Q9zs50RGVGVrLszCcsIZYuBfhK8hzOYyLzxo85+cjyy3Y6+CRLvulxEvYCRbSsbvprfo9sdpHK4Uj FoJ1Em4AWcayyKNIebOizA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP1Oq-0005bn-7N; Mon, 06 Feb 2023 08:19:12 -0500 In-Reply-To: <87o7q7dl4o.fsf@masteringemacs.org> (message from Mickey Petersen on Mon, 06 Feb 2023 12:35:20 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254957 Archived-At: > From: Mickey Petersen > Cc: Yuan Fu , 61235@debbugs.gnu.org > Date: Mon, 06 Feb 2023 12:35:20 +0000 > > > I'm not sure I understand the need. AFAIU, a parser is deleted only > > if we call treesit-parser-delete; are we saying that a Lisp program > > doesn't know that it deleted a parser? What exactly is the practical > > situation where this problem happens, and why? > > > > Frankly, I don't think we should at this stage add APIs without a very > > good reason. We should instead collect experience, both from users > > and from Lisp programs, and analyze them before deciding whether more > > APIs are necessary. > > > > Because node references are retained even after a parser is deleted. > > Retrieving a node; somehow deleting the parser (maybe you closed the > buffer, or you were doing some off-hand parsing); and then doing > _anything_ with the aforementioned node yields an error for which > there is no way to test for. > > This is particularly the case when you mix and match parsers in the > same buffer. I'm asking why the Lisp program cannot track the parsers its uses and deletes, and instead expects the core to do the janitor's job for it.