From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61548: 30.0.50; Command 'keymap-global-set' fails when called interactively Date: Thu, 16 Feb 2023 10:42:21 +0200 Message-ID: <83a61e80ia.fsf@gnu.org> References: <87o7pukw5l.fsf@syslbnth.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33924"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61548@debbugs.gnu.org To: phantom@syslbnth.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 16 09:43:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pSZrH-0008bR-7W for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Feb 2023 09:43:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSZr6-0008TW-Tf; Thu, 16 Feb 2023 03:43:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSZr5-0008TF-4b for bug-gnu-emacs@gnu.org; Thu, 16 Feb 2023 03:43:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSZr4-0008Qx-RX for bug-gnu-emacs@gnu.org; Thu, 16 Feb 2023 03:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pSZr4-0001q0-Fw for bug-gnu-emacs@gnu.org; Thu, 16 Feb 2023 03:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Feb 2023 08:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61548 X-GNU-PR-Package: emacs Original-Received: via spool by 61548-submit@debbugs.gnu.org id=B61548.16765369687041 (code B ref 61548); Thu, 16 Feb 2023 08:43:02 +0000 Original-Received: (at 61548) by debbugs.gnu.org; 16 Feb 2023 08:42:48 +0000 Original-Received: from localhost ([127.0.0.1]:34823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSZqp-0001pU-PA for submit@debbugs.gnu.org; Thu, 16 Feb 2023 03:42:48 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSZqn-0001pE-Rt for 61548@debbugs.gnu.org; Thu, 16 Feb 2023 03:42:46 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSZqi-0008N1-Ee; Thu, 16 Feb 2023 03:42:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=6DCE5oBbiegcWz7BDNDxgtAgRqW6pQpUPTNeSCG8By0=; b=akVCWJWa7DQwx3QoHyVI oWfP3WOXmVF7+T9m9/3tSEqr5bwLLLlouFfVgmYVsMouPu+7fHTfsjJX96EMS4B/lez+4MDN3KMu5 TrtayR8YEuqqFT0K7S351PzvVV/NIpllIlST/F1HEYXfT3j0+/QpzLZIabxDuQ2bKaE3hYom6H98l NxUCnKTCpaq4s8QyeQ3WI4KYjVXfrTMTfOGNBPo8ou9lm0ohM5oWi40JXBb5fgDKKCxbivarqLHZb rIP1L17YpT1vtWfeA9s5/Oiw9CNT1fJIDr7uf8DRza4bFB0K+bjBMCets8hukEH+CteCXsVQ09Upa kCVJH8DWyiFqzw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSZqf-0005NM-TZ; Thu, 16 Feb 2023 03:42:39 -0500 In-Reply-To: <87o7pukw5l.fsf@syslbnth.com> (phantom@syslbnth.com) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255802 Archived-At: > From: phantom@syslbnth.com > Date: Thu, 16 Feb 2023 00:37:58 -0500 > > Calling 'keymap-global-set' interactively fails with the message > > keymap--check: INPUT is not a valid key definition; see ‘key-valid-p’ > > where INPUT is the printed representation of the key sequence entered, > unless that sequence is a single unmodified key. And even among those, I > only know alphanumeric keys to be exempt; , and > anything you have to put in will cause trouble. > > >From 'emacs -Q', simply type > > M-x keymap-global-set RET You mean, you get the error after typing "M-x keymap-global-set RET"? If so, I cannot reproduce this with today's master. I did: emacs -Q M-x keymap-global-set RET C-x g goto-char RET (where "C-x g" is a key sequence, i.e. press Ctrl and x, then press g) and didn't see any errors. > The problem is that the output from 'read-key-sequence', which is called > by 'keymap-global-set', is not filtered through 'key-description' before > being assigned to KEY: > > (interactive > (let* ((menu-prompting nil) > (key (read-key-sequence "Set key globally: " nil t))) ; error > (list key > (read-command (format "Set key %s to command: " > (key-description key)))))) This code is not in the current function on the master branch. Are you sure your sources are up to date?