From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61639: 30.0.50; [PATCH] Do not error out on non image file in image-dired Date: Wed, 22 Feb 2023 15:22:11 +0200 Message-ID: <83a615sum4.fsf@gnu.org> References: <87sff1quwk.fsf@ledu-giraud.fr> <83sff0v6wz.fsf@gnu.org> <87ttzgtq6p.fsf@ledu-giraud.fr> <83edqkv48n.fsf@gnu.org> <87k00ctofi.fsf@ledu-giraud.fr> <83a618v1jj.fsf@gnu.org> <87bklothkw.fsf@ledu-giraud.fr> <83ttzfteg1.fsf@gnu.org> <87y1orrz7f.fsf@ledu-giraud.fr> <83cz63tbkf.fsf@gnu.org> <87mt57kshm.fsf@ledu-giraud.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39739"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61639-done@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 22 14:23:34 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pUp5p-000ACR-TY for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 Feb 2023 14:23:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUp5M-0003Fh-Jn; Wed, 22 Feb 2023 08:23:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUp5K-0003Ey-IE for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2023 08:23:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUp5K-0001yo-A0 for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2023 08:23:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pUp5K-0002KG-5l for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2023 08:23:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Feb 2023 13:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 61639 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 61639@debbugs.gnu.org, eliz@gnu.org, manuel@ledu-giraud.fr Original-Received: via spool by 61639-done@debbugs.gnu.org id=D61639.16770721258840 (code D ref 61639); Wed, 22 Feb 2023 13:23:01 +0000 Original-Received: (at 61639-done) by debbugs.gnu.org; 22 Feb 2023 13:22:05 +0000 Original-Received: from localhost ([127.0.0.1]:58294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUp4P-0002IW-3n for submit@debbugs.gnu.org; Wed, 22 Feb 2023 08:22:05 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUp4N-0002I0-4Q for 61639-done@debbugs.gnu.org; Wed, 22 Feb 2023 08:22:03 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUp4H-0001rY-9k; Wed, 22 Feb 2023 08:21:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=AgtRDBQnEbEiZI8oyxmv1wOiJlS/pmKdF3cGmQdtrqs=; b=Lj45EIcppMsBR2J+5ohI SgFSRJfakRx0jxgO4KZsn4QjXr1OUrxjF4xYMQuAjLBxfD9/o4ZWsAKovQH0qrz9k7kxNaAwh51qB V21ShzaY2nxKdprqdd/r/kp4DqVckSDAiJee8M8t4ak3LeEmtuNsm2KT1H6yMLJ8Shqjg2lU5T1tn JK6tkFMCj8kjoHTl2x81zBZ7li+JMDwV4HUIugr48fAlcaoEe+tpYxnDAnUm9UhCkmfOS6d6JbabL BqIJ7MB+qNFs9anNvKJIN0FI3imLW4vHMzSNWxq/Oa5vDGpZippmWW2OboeeHu2VYsU5l7pa9hchy XYZcB5ujZQTAQw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUp4G-0005KZ-It; Wed, 22 Feb 2023 08:21:56 -0500 In-Reply-To: <87mt57kshm.fsf@ledu-giraud.fr> (message from Manuel Giraud on Tue, 21 Feb 2023 15:23:01 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256344 Archived-At: > From: Manuel Giraud > Cc: 61639@debbugs.gnu.org > Date: Tue, 21 Feb 2023 15:23:01 +0100 > > Eli Zaretskii writes: > > [...] > > >> 'plusp' is a classic Common Lisp predicate (that also seems to be > >> defined in Emacs). It is equivalent to (> x 0)… maybe you prefer that. > >> Should I fix my patch? > > > > Where is it defined? It isn't defined in "emacs -Q", and not after > > loading image-dired. (Tested in Emacs 29.) > > C-h f gives me this: > --8<---------------cut here---------------start------------->8--- > plusp is an alias for ‘cl-plusp’ in ‘cl.el’. > > This function is obsolete since 27.1; use ‘cl-plusp’ instead. > --8<---------------cut here---------------end--------------->8--- > > … anyway here is an updated version of the patch to avoid this. Thanks, I installed this on the emacs-29 branch, and closing the bug.