unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Manuel Giraud <manuel@ledu-giraud.fr>
Cc: 61639-done@debbugs.gnu.org
Subject: bug#61639: 30.0.50; [PATCH] Do not error out on non image file in image-dired
Date: Wed, 22 Feb 2023 15:22:11 +0200	[thread overview]
Message-ID: <83a615sum4.fsf@gnu.org> (raw)
In-Reply-To: <87mt57kshm.fsf@ledu-giraud.fr> (message from Manuel Giraud on Tue, 21 Feb 2023 15:23:01 +0100)

> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: 61639@debbugs.gnu.org
> Date: Tue, 21 Feb 2023 15:23:01 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> [...]
> 
> >> 'plusp' is a classic Common Lisp predicate (that also seems to be
> >> defined in Emacs).  It is equivalent to (> x 0)… maybe you prefer that.
> >> Should I fix my patch?
> >
> > Where is it defined?  It isn't defined in "emacs -Q", and not after
> > loading image-dired.  (Tested in Emacs 29.)
> 
> C-h f gives me this:
> --8<---------------cut here---------------start------------->8---
> plusp is an alias for ‘cl-plusp’ in ‘cl.el’.
> 
> This function is obsolete since 27.1; use ‘cl-plusp’ instead.
> --8<---------------cut here---------------end--------------->8---
> 
> … anyway here is an updated version of the patch to avoid this.

Thanks, I installed this on the emacs-29 branch, and closing the bug.





      reply	other threads:[~2023-02-22 13:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-19 20:09 bug#61639: 30.0.50; [PATCH] Do not error out on non image file in image-dired Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-20 12:49 ` Eli Zaretskii
2023-02-20 13:35   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-20 13:46     ` Eli Zaretskii
2023-02-20 14:13       ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-20 14:45         ` Eli Zaretskii
2023-02-20 16:41           ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-21 12:01             ` Eli Zaretskii
2023-02-21 12:16               ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-21 13:03                 ` Eli Zaretskii
2023-02-21 14:23                   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-22 13:22                     ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83a615sum4.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=61639-done@debbugs.gnu.org \
    --cc=manuel@ledu-giraud.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).