From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61726: [PATCH] Eglot: Support positionEncoding capability Date: Sat, 25 Feb 2023 12:57:04 +0200 Message-ID: <83a612ko73.fsf@gnu.org> References: <87a614g628.fsf@gmail.com> <83v8jspgnr.fsf@gnu.org> <87lekodxja.fsf@gmail.com> <83a614p4sh.fsf@gnu.org> <87cz60dus9.fsf@gmail.com> <835ybrpnqj.fsf@gnu.org> <87y1oncz09.fsf@gmail.com> <83r0ufo3uc.fsf@gnu.org> <87356vbf0b.fsf@gmail.com> <83pm9znw0i.fsf@gnu.org> <87lekn9ss3.fsf@gmail.com> <83h6vbntqd.fsf@gnu.org> <878rgn9r6u.fsf@gmail.com> <83edqfnq5u.fsf@gnu.org> <83bkljnpck.fsf@gnu.org> <874jrb9l6d.fsf@gmail.com> <834jrbnlaf.fsf@gnu.org> <87v8jr83ic.fsf@gmail.com> <83v8jrm4r0.fsf@gnu.org> <87fsav7x81.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32603"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61726@debbugs.gnu.org, joaotavora@gmail.com To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 25 11:58:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVsFp-0008Lx-Hq for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Feb 2023 11:58:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVsFh-00080Z-Cm; Sat, 25 Feb 2023 05:58:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVsFe-0007xv-WD for bug-gnu-emacs@gnu.org; Sat, 25 Feb 2023 05:58:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVsFe-0004wW-OC for bug-gnu-emacs@gnu.org; Sat, 25 Feb 2023 05:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pVsFe-0000Zm-6R for bug-gnu-emacs@gnu.org; Sat, 25 Feb 2023 05:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Feb 2023 10:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61726 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61726-submit@debbugs.gnu.org id=B61726.16773226302151 (code B ref 61726); Sat, 25 Feb 2023 10:58:02 +0000 Original-Received: (at 61726) by debbugs.gnu.org; 25 Feb 2023 10:57:10 +0000 Original-Received: from localhost ([127.0.0.1]:39256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVsEn-0000Yd-UK for submit@debbugs.gnu.org; Sat, 25 Feb 2023 05:57:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVsEm-0000YR-74 for 61726@debbugs.gnu.org; Sat, 25 Feb 2023 05:57:09 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVsEg-0003v3-Mh; Sat, 25 Feb 2023 05:57:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=FB1fOhxc8g8+jlJ/M1BzwSF3vGyg+vVVzqvWXRcpkeo=; b=r2pE/C2k6Dzt UIzBzwTgk7fMEJIM+9lLyt/h2V6tchZwBsbic2K9mrbO+s4pnwIwIoCFsF91vwTSuxSQaIMNHVrTK VS6utDemlBbEL04l1jbUbHd4NBiqqEd+OuyHMAX99Wz4FOURJVfStymoChI2XcX7ih/XWtV7gtOlX Wj/oB1aw8rrZG/A8OdY5h/3CgCpZosOOotcvkoGHwJP1GGXT5CYUpmchvD+KEexNCOhPmx74V1etC zr0r/2EwnrSQ+RnjefqKfi18DoikvQv7oLeJJVKhEVi0XtoHs86k8lPDFlT6137RU7Wepxju0XK/r i5bsbf/btstRiHgXwfis8g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVsEg-0001j6-2j; Sat, 25 Feb 2023 05:57:02 -0500 In-Reply-To: <87fsav7x81.fsf@gmail.com> (message from Augusto Stoffel on Fri, 24 Feb 2023 19:08:14 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256708 Archived-At: > From: Augusto Stoffel > Cc: joaotavora@gmail.com, 61726@debbugs.gnu.org > Date: Fri, 24 Feb 2023 19:08:14 +0100 > > I also didn't attempt to make 'eglot-move-to-bytewise-column' and > 'eglot-bytewise-column' "correct" in the cases where 'json-serialize' > throws an error. I think it's clear that Eli and I have different > definitions "correctness" in this context, but Eli's proposal requires > substantial further work, including recovering from possible errors > raising from 'json-serialize'. No, it doesn't. All I'm asking for is to use encode-coding-string or encode-coding-region to measure the actual number of bytes in a UTF-8 sequence that corresponds to a region of text. Nothing else is required or requested. Can you please humor me and implement eglot-bytewise-column like that?