From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64311: [PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated buffers Date: Thu, 29 Jun 2023 21:10:14 +0300 Message-ID: <83a5wita0p.fsf@gnu.org> References: <87pm5h4iy1.fsf@t510.orion.oneofus.la> <83h6qtw3tq.fsf@gnu.org> <87wmzp2e0d.fsf@t510.orion.oneofus.la> <831qhwx5qf.fsf@gnu.org> <87zg4k76es.fsf@orphne.orion.oneofus.la> <83mt0jvmfu.fsf@gnu.org> <87r0pva66g.fsf@t510.orion.oneofus.la> <834jmrv3p6.fsf@gnu.org> <87o7kz9wej.fsf@t510.orion.oneofus.la> <83wmzmuaq7.fsf@gnu.org> <87wmzmb5fl.fsf@t510.orion.oneofus.la> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15044"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64311@debbugs.gnu.org To: Vladimir Sedach Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 29 20:10:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qEw66-0003j0-B2 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Jun 2023 20:10:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qEw5o-0005jc-Gh; Thu, 29 Jun 2023 14:10:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEw5j-0005c4-Ga for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2023 14:10:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qEw5i-0008Q3-V3 for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2023 14:10:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qEw5i-0002Da-6q for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2023 14:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Jun 2023 18:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64311 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64311-submit@debbugs.gnu.org id=B64311.16880621998512 (code B ref 64311); Thu, 29 Jun 2023 18:10:02 +0000 Original-Received: (at 64311) by debbugs.gnu.org; 29 Jun 2023 18:09:59 +0000 Original-Received: from localhost ([127.0.0.1]:53990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEw5e-0002DD-HL for submit@debbugs.gnu.org; Thu, 29 Jun 2023 14:09:58 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEw5Z-0002Cu-SX for 64311@debbugs.gnu.org; Thu, 29 Jun 2023 14:09:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEw5T-0008Nn-R6; Thu, 29 Jun 2023 14:09:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=IBb9C9/sAM8cE23W68ZzcVROUwQ4U/7aDwLaZnXwPL0=; b=jALqHAkuSDB8 gA2zRg9K+cgjSbGZ4qwAmdWuiRp9xUuxaYfVm7/nSmITVHVGOCfL3hBHwO85qdOrsy7w8rHMc+BmB YnSME2fT9S0LVoWLZpibr6jYGBvStC8e4WCp0sIMTgGM11qMNkRn79kmGf5KsFKredIfbrZkYe5SV IKdceDFBYpBmor0fw1X11EFRtogzT7lAKy9f2Lrco9eGZuM35Btxno0EbLzMdxpt80ZdAGqU6RTIq Oyv4LNxuVkYqPOUHK/v88vGA0kstlSRnsAdaGWLF6O/5fmc3bBlBq3aJXSefkln+zcsauE0tPmswz CON7TXf8geu11LMLa2FSdw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEw5T-0002Rj-Al; Thu, 29 Jun 2023 14:09:47 -0400 In-Reply-To: <87wmzmb5fl.fsf@t510.orion.oneofus.la> (message from Vladimir Sedach on Thu, 29 Jun 2023 10:26:38 -0600) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264286 Archived-At: > From: Vladimir Sedach > Cc: 64311@debbugs.gnu.org > Date: Thu, 29 Jun 2023 10:26:38 -0600 > > > Eli Zaretskii writes: > > > So making the default value nil will solve the problem? > > Yes, but you are asking the wrong question. Am I? Asking about the root cause of the problem is not wrong, because it indicates how best to fix it. > When I came upon this problem, the first questions I had were: what > is the variable shell-dirtrackp, and why is it aliased to > shell-dirtrack-mode? Why would we bother about that? With the exception of the default value, what harm does that variable cause by existing? > This is why I came up with a fix that follows the X-mode control > variable convention, marks the redundant variable obsolete, replaces > any leftover references to the redundant variable with > shell-dirtrack-mode, and adds unit tests for the control paths of the > affected code. Sorry, I'm not interested in making changes unrelated to the problem. Making a variable obsolete causes Emacs emit annoying messages when the variable is used, and that can be justified only if the variable gets in the way. This one doesn't. So I think we should just make the default value nil, and be done.