From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Mon, 17 Jul 2023 05:23:46 +0300 Message-ID: <83a5vv8edp.fsf@gnu.org> References: <877cr4nez9.fsf@localhost> <83lefj4okb.fsf@gnu.org> <83fs5r3tqv.fsf@gnu.org> <834jm6fppc.fsf@gnu.org> <87a5vyidy6.fsf@localhost> <83sf9qe2ip.fsf@gnu.org> <83a5vxejz6.fsf@gnu.org> <87ttu4gnpt.fsf@localhost> <83bkgb8xo5.fsf@gnu.org> <87jzuz1uq5.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12796"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, 64596@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 17 04:24:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qLDuK-00039w-CQ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 Jul 2023 04:24:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLDu8-0007E2-QL; Sun, 16 Jul 2023 22:24:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLDu6-0007Dd-U2 for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 22:24:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLDu6-0000j1-Le for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 22:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qLDu5-0004K5-TO for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 22:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Jul 2023 02:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.168956061316580 (code B ref 64596); Mon, 17 Jul 2023 02:24:01 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 17 Jul 2023 02:23:33 +0000 Original-Received: from localhost ([127.0.0.1]:48775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLDtc-0004JM-TV for submit@debbugs.gnu.org; Sun, 16 Jul 2023 22:23:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLDtX-0004J6-On for 64596@debbugs.gnu.org; Sun, 16 Jul 2023 22:23:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLDtS-0000Xn-7b; Sun, 16 Jul 2023 22:23:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZNpJd8yFIarfrv30WEjSX53CLHu/yzOB+DM9eyYdK4A=; b=n/UVdt5X2M2T IY2qQiPTEe/8lxmr71Arcf4heMGW3EPBrC2rjOKsK7fnPpYWRnfxiAPbGijAQKItq5InclHn1JzW5 g48KtbhEIsgp9zLjGXH+KnfdYB83iah32uISLCdZCFX/JxVFuEaeaVN0Xi2V14f85X/Iy3WQR280E yvfqUi//MZ5054dcXNCIjIjGd/BjKfEbEP6hZDiJQvH0nG3vZxO3E88a2tm2AsvsQAcFBSUw803QI 2pm5KGdQHPaF/QzvbmwXvHJyVKl7Y7xDMUSEnFJuAr8K97dKiJ+sNBUA9S/dlGeUYPSqGhS2nXyjw DR9pw4Y7pjimu6wru8gegA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLDtR-0000xT-So; Sun, 16 Jul 2023 22:23:22 -0400 In-Reply-To: <87jzuz1uq5.fsf@localhost> (message from Ihor Radchenko on Sun, 16 Jul 2023 20:12:34 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265368 Archived-At: > From: Ihor Radchenko > Cc: monnier@iro.umontreal.ca, 64596@debbugs.gnu.org > Date: Sun, 16 Jul 2023 20:12:34 +0000 > > Eli Zaretskii writes: > > > Actually, the must_be_updated_p flag is not for xdisp.c, i.e. not for > > redisplay_window and its subroutines. It is for update_window, which > > is the last, 3rd, stage of a redisplay cycle, most of the code of > > which is in dispnew.c. That's where the newly computed glyph matrix > > of a window is compared to its current matrix, and Emacs decides what, > > if anything, should be actually written to the glass. What happens > > with this flag is that redisplay_window and friends _set_ this flag > > for windows that dispnew.c _must_ update. The flag is tested in > > dispnew.c, see there for its use and comments. > > I see. > > I have to say that these flag names are very disorienting. > I have first seen this flag while reading xdisp.c, and it was not obvious > at all what it does. Well, update_frame and update_window are the relevant functions in dispnew.c, so "must_be_updated_p" kind-of points to them.