From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62216: Odd file corruption in clojure mode and emacs 30 HEAD Date: Wed, 30 Aug 2023 15:00:59 +0300 Message-ID: <83a5u8hh8k.fsf@gnu.org> References: <83jztpwx92.fsf@gnu.org> <875y58bv5w.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9103"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, jcm@SDF.ORG, eggert@cs.ucla.edu, 62216@debbugs.gnu.org To: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 30 14:02:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbJtk-00029h-8z for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Aug 2023 14:02:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbJtU-0004Sr-Ii; Wed, 30 Aug 2023 08:01:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbJtS-0004R3-KV for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2023 08:01:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbJtS-0006tx-C6 for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2023 08:01:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qbJtZ-0008QK-RE for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2023 08:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Aug 2023 12:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62216 X-GNU-PR-Package: emacs Original-Received: via spool by 62216-submit@debbugs.gnu.org id=B62216.169339689832350 (code B ref 62216); Wed, 30 Aug 2023 12:02:01 +0000 Original-Received: (at 62216) by debbugs.gnu.org; 30 Aug 2023 12:01:38 +0000 Original-Received: from localhost ([127.0.0.1]:52308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbJtC-0008Pi-6y for submit@debbugs.gnu.org; Wed, 30 Aug 2023 08:01:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbJtA-0008PV-1B for 62216@debbugs.gnu.org; Wed, 30 Aug 2023 08:01:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbJsv-0006md-ST; Wed, 30 Aug 2023 08:01:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=72w/5RBdz+ZEW/ozZSJ3NPaPsFzfxCLtOwU+9LVGj6c=; b=cCUoA2ufXLDRX/nCsm9h T2hepZDYuPwf8ACAVlaGc5AgYtuimdFrSfLkADU8fgIGKvoInHDdiFWXgtWPFqE5MHa/6zbVjeYPD 3fE3r/MRbJ1Rp32m8qfHv298nu9KXzR/DCcSFSo7/Bw6Ap/mjLarDj1tjNKx4MeANXrWGepdHc1Ni s9PHD90+kFSd1mv0JC9UkF2kGaTMfKH4fkTjeU1Dt64sblKhqXWvrRemw3i39QltQkZGnH1QuS1ke EBfvrBxk/7HKPGGuSP2WTMB0IpHCVf7yCciZQF7Ih0eq1iHf0PZo3lqY52lATl8HsGcGY6k/FOGWW ZM5Lhu5H7TSjeA==; In-Reply-To: (message from Gerd =?UTF-8?Q?M=C3=B6llmann?= on Wed, 30 Aug 2023 10:59:08 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268701 Archived-At: > From: Gerd Möllmann > Cc: Jonathon McKitrick , Eli Zaretskii , Paul > Eggert , 62216@debbugs.gnu.org > Date: Wed, 30 Aug 2023 10:59:08 +0200 > > Po Lu writes: > > > Jonathon McKitrick writes: > > > >> What's the best mechanism to log these values in emacs? > > > > In this case, printf. > > When I add this assumption: > > modified src/fileio.c > @@ -4805,8 +4805,11 @@ DEFUN ("insert-file-contents", Finsert_file_contents, Sinsert_file_contents, > > /* 'try' is reserved in some compilers (Microsoft C). */ > ptrdiff_t trytry = min (gap_size, READ_BUF_SIZE); > + ptrdiff_t trytry_old = min (total - inserted, READ_BUF_SIZE); > if (!NILP (end)) > trytry = min (trytry, total - inserted); > + if (trytry != trytry_old) > + abort (); > > if (!seekable && NILP (end)) > { > > and make bootstrap, temacs aborts. > > Can someone tell if this assumption should hold? You expect READ_BUF_SIZE to never be greater than gap_size?