From: Eli Zaretskii <eliz@gnu.org>
To: Jonas Bernoulli <jonas@bernoul.li>
Cc: smfadi@gmail.com, 64998@debbugs.gnu.org
Subject: bug#64998: 29.1; `emoji-search' (C-x 8 e s) command can not be repeated using `repeat' (C-x z)
Date: Sun, 03 Sep 2023 19:22:15 +0300 [thread overview]
Message-ID: <83a5u36xc8.fsf@gnu.org> (raw)
In-Reply-To: <877cp7p6y6.fsf@bernoul.li> (message from Jonas Bernoulli on Sun, 03 Sep 2023 18:17:21 +0200)
> From: Jonas Bernoulli <jonas@bernoul.li>
> Cc: 64998@debbugs.gnu.org
> Date: Sun, 03 Sep 2023 18:17:21 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Fadi Moukayed <smfadi@gmail.com>
>
> >> Observed behavior:
> >>
> >> No "up arrow" emoji is inserted.
> >>
> >> The following messages are written on the *Messages* buffer:
> >>
> >> Repeating command minibuffer-complete-and-exit
> >> No match
> >
> > That command is implemented on top of transient.el, and I'm not sure
> > transient supports "C-x z" repetition. Jonas, can you comment on
> > this, please?
>
> Support implemented in 502e7c9a9b34c74b1b99f9e2f13a75f03dabba18 (and
> a little follow up commit to fix a last minute hiccup).
Thanks!
I see you installed this on master. I would like to fix this on the
emacs-29 branch instead, since these commands are new in Emacs 29. Do
you think it's okay to cherry-pick your two commits to emacs-29? I'm
asking because AFAIR you made some changes in transient.el on master,
and I'm not sure whether the fixes you made today need those changes
to work.
next prev parent reply other threads:[~2023-09-03 16:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 16:11 bug#64998: 29.1; `emoji-search' (C-x 8 e s) command can not be repeated using `repeat' (C-x z) Fadi Moukayed
2023-08-01 18:08 ` Eli Zaretskii
2023-08-12 6:44 ` Eli Zaretskii
2023-08-12 21:44 ` Jonas Bernoulli via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-02 18:42 ` Eli Zaretskii
2023-09-03 16:17 ` Jonas Bernoulli via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-03 16:22 ` Eli Zaretskii [this message]
2023-09-03 20:57 ` Jonas Bernoulli via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-04 11:28 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a5u36xc8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=64998@debbugs.gnu.org \
--cc=jonas@bernoul.li \
--cc=smfadi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).