From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66326: 29.1.50; There should be a way to promote warnings to errors Date: Sun, 15 Oct 2023 08:45:36 +0300 Message-ID: <83a5skqvzz.fsf@gnu.org> References: <83y1gj5ya9.fsf@gnu.org> <87wmw3zfd3.fsf@catern.com> <83wmw353ny.fsf@gnu.org> <83mswlslxu.fsf@gnu.org> <87o7h0yh7k.fsf@catern.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35349"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@janestreet.com, 66326@debbugs.gnu.org To: sbaugh@catern.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 15 07:47:02 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qrtxt-0008xW-Cm for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 15 Oct 2023 07:47:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qrtxb-0004r8-4J; Sun, 15 Oct 2023 01:46:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrtxW-0004qt-QO for bug-gnu-emacs@gnu.org; Sun, 15 Oct 2023 01:46:40 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qrtxV-0007w7-RF for bug-gnu-emacs@gnu.org; Sun, 15 Oct 2023 01:46:38 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qrtxt-0005TU-Qb for bug-gnu-emacs@gnu.org; Sun, 15 Oct 2023 01:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Oct 2023 05:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66326 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66326-submit@debbugs.gnu.org id=B66326.169734878420990 (code B ref 66326); Sun, 15 Oct 2023 05:47:01 +0000 Original-Received: (at 66326) by debbugs.gnu.org; 15 Oct 2023 05:46:24 +0000 Original-Received: from localhost ([127.0.0.1]:51109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrtxH-0005SU-I6 for submit@debbugs.gnu.org; Sun, 15 Oct 2023 01:46:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrtxG-0005SH-3C for 66326@debbugs.gnu.org; Sun, 15 Oct 2023 01:46:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrtwk-0007tl-Kq; Sun, 15 Oct 2023 01:45:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RnCvE4A5jzCwgFR3w9BWrolgQWO1rqnJCd064OMmhOI=; b=qefiJBOhU2LS pprlNuoStOf8kpR7JFl3525N4D/9CiqaAWv+qArLIejsLqgpS4fqQosKuf81WsKkePHOqkjI2gvv3 RQU0WyDUncdnWr3xtKzHO42RmUhN+ENGZqx7lQZEr5NyPDCjDwMXbVVFRp+W6oZ71X7Si626fSkoe OEEihCQDgOJ9iiU6/WacOJxFJZNN5miPR81F8HCmNlbCXezdLXBwav8ezA8CzJs2LGg/inL8uMilj p0rXZ49KdIVHRs2H/nrImoe3EIzcTp1X5+RVvFuyBaaUydQAFqr/mvxtZsW9db2iP7wbvQHShzXwo RH4GffRA6w4BAYkg0pt+Pg==; In-Reply-To: <87o7h0yh7k.fsf@catern.com> (sbaugh@catern.com) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272484 Archived-At: > From: sbaugh@catern.com > Date: Sat, 14 Oct 2023 22:25:37 +0000 (UTC) > Cc: Spencer Baugh , 66326@debbugs.gnu.org > > Eli Zaretskii writes: > > >> From: Spencer Baugh > >> Cc: sbaugh@catern.com, 66326@debbugs.gnu.org > >> Date: Wed, 04 Oct 2023 08:20:49 -0400 > >> > >> Eli Zaretskii writes: > >> > And in this case, duplication is a lesser evil than reordering of > >> > logic, since the chances of unintended consequences would be lower in > >> > the former case. > >> > >> OK, how about this version then? > > > > This is much better, thanks. But it still fails to execute this part > > right away: > > > > (if (not (or after-init-time noninteractive (daemonp))) > > ;; Ensure warnings that happen early in the startup sequence > > ;; are visible when startup completes (bug#20792). > > (delay-warning type message level buffer-name) > > > > We must preserve this functionality, unaffected by these changes. The > > patch you propose doesn't seem to guarantee that, at least not > > clearly enough for my palate. > > Ah, actually that's deliberate. If it's deliberate, it will have to come with an additional option to enable it. I don't want users to have their startup aborted just because they want some warning later on converted to an error. Startup is a delicate process where signaling errors is not always a good idea, and we delay warnings there for a good reason. Changing this unconditionally is not acceptable. > (And that's one of the motivations of this change: to make it easier to > debug a warning that happens during startup, by turning it into an error > that can be debug-init'd) There's no difficulty in debugging a warning whatsoever, IME. It is a serious exaggeration to claim that there's a significant problem here that needs a solution. Nevertheless, I'm okay with people opting in to shooting themselves in the foot, I just don't agree to doing that without an explicit user's consent.