From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#16331: 24.3.50; `dired-internal-do-deletions': "Deleting..." message Date: Sat, 8 Feb 2014 07:06:33 -0800 (PST) Message-ID: <839a6591-081d-4a2f-869c-26a4b73f2899@default> References: <8a572886-e141-4cad-a9db-9acbc3daaa5f@default> <87mwi2b9s4.fsf@building.gnus.org> <9d2961a4-ff90-4a14-8582-c5934adc5558@default> <87y51m8ejp.fsf@building.gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1391872040 1394 80.91.229.3 (8 Feb 2014 15:07:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 8 Feb 2014 15:07:20 +0000 (UTC) Cc: 16331@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 08 16:07:25 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WC9V6-0004ve-I2 for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Feb 2014 16:07:24 +0100 Original-Received: from localhost ([::1]:46876 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WC9V5-00047B-UJ for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Feb 2014 10:07:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WC9Uu-00046l-I2 for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2014 10:07:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WC9Uk-0005Kl-JV for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2014 10:07:12 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44012) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WC9Uk-0005Kg-Fr for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2014 10:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WC9Uj-0008Bg-N0 for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2014 10:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Feb 2014 15:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16331 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16331-submit@debbugs.gnu.org id=B16331.139187200531445 (code B ref 16331); Sat, 08 Feb 2014 15:07:01 +0000 Original-Received: (at 16331) by debbugs.gnu.org; 8 Feb 2014 15:06:45 +0000 Original-Received: from localhost ([127.0.0.1]:58031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WC9US-0008B6-4M for submit@debbugs.gnu.org; Sat, 08 Feb 2014 10:06:44 -0500 Original-Received: from userp1040.oracle.com ([156.151.31.81]:48647) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WC9UO-0008Ax-Ng for 16331@debbugs.gnu.org; Sat, 08 Feb 2014 10:06:41 -0500 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s18F6a69029132 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 8 Feb 2014 15:06:37 GMT Original-Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s18F6ZX0017771 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 8 Feb 2014 15:06:36 GMT Original-Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userz7022.oracle.com (8.14.5+Sun/8.14.4) with ESMTP id s18F6Y98009841; Sat, 8 Feb 2014 15:06:34 GMT In-Reply-To: <87y51m8ejp.fsf@building.gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:84966 Archived-At: > I tried edebugging through the function. It asked me first whether > to delete the files in question, and then it used the >=20 > =09 (progress-reporter > =09 (make-progress-reporter > =09 (if trashing "Trashing..." "Deleting...") > =09 succ count))) >=20 > to display "Deleting... [33%]". But that was when it's actually > deleting something. >=20 > I can't see the progress reported being used before that, but I may > be misreading the code. Yes, I believe you are. And apparently you are also mis-seeing what you see (not noticing the "Deleting..." message appear first). Not only do I see what I said, but this is what debug shows the progress reporter doing: Debugger entered--entering a function: * message("%s" "Deleting...") * progress-reporter-do-update((1 . [1391871442.1130002 0 5 "Deleting..." 1 0.2]) 0) * make-progress-reporter("Deleting..." 0 5) * (let* ((files (mapcar (function car) l)) ... And if you `M-x debug-on-entry RET dired-internal-do-flagged-delete' then you will see that it immediately calls `dired-internal-do-deletions'. `dired-internal-do-deletions' _first_, in its `let*'-form, calls `make-progress-reporter', which shows the message "Deleting...". Only _after_ that, in the `let*'-body, does it call `dired-mark-pop-up', which pops up the list of files and asks for confirmation.