From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#45264: 26.3; `face-remap-set-base' seems to be bugged Date: Sat, 19 Dec 2020 11:28:31 -0800 (PST) Message-ID: <8397c6ee-966d-4d34-9a64-2dde3515cedd@default> References: <<>> <<<833602umgb.fsf@gnu.org>>> <<4efb5c63-6636-449f-8e2b-4b8533a9cc8c@default>> <<83a6u9tyh1.fsf@gnu.org>> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32028"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45264-done@debbugs.gnu.org To: Eli Zaretskii , Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 19 20:43:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kqi8M-0008G0-OH for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Dec 2020 20:43:18 +0100 Original-Received: from localhost ([::1]:46028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqi8L-0001sn-Nk for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Dec 2020 14:43:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40048) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kqhuY-0003gC-Cl for bug-gnu-emacs@gnu.org; Sat, 19 Dec 2020 14:29:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59884) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kqhuY-0002la-4p for bug-gnu-emacs@gnu.org; Sat, 19 Dec 2020 14:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kqhuX-0002ry-VY for bug-gnu-emacs@gnu.org; Sat, 19 Dec 2020 14:29:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Dec 2020 19:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45264 X-GNU-PR-Package: emacs Original-Received: via spool by 45264-done@debbugs.gnu.org id=D45264.160840612210999 (code D ref 45264); Sat, 19 Dec 2020 19:29:01 +0000 Original-Received: (at 45264-done) by debbugs.gnu.org; 19 Dec 2020 19:28:42 +0000 Original-Received: from localhost ([127.0.0.1]:43197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqhuD-0002rL-Tf for submit@debbugs.gnu.org; Sat, 19 Dec 2020 14:28:42 -0500 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:49738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqhuB-0002r6-0S for 45264-done@debbugs.gnu.org; Sat, 19 Dec 2020 14:28:40 -0500 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BJJKCbV144414; Sat, 19 Dec 2020 19:28:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=OOda8gVKEOzVRGEcvYS+asblk2bmWQ4u+FJvHtwG4z0=; b=RIPzdMGLlHcsG9N6IAxnLjdAWgD/0PBmp+Cwr26OoGVXFUlil6ro1zTDn9UtBm01d6lI sIkSpUMfUyHqQhLlq8UtgSnAitkPKBXRvrTEOAcfhMflg8neXSTxoq5bqdcOPBZ1EuZT OCRHZdSNklUL01K4XJqfyarraCQbTcz56bvuAsS5Kwz6ZCLlGdHJWJ27f7RkSLVbWsQj L3gU0Y9NydgeYgxdW1DdStRk9Yk4PFwEAOEmFcP+Ck1Enbb5JF00T0/JmXbrUeue9Xtp fFrmTEcQhKG0UTfQy+pHil9ZsQIAohhymr+UAgy/0cbQIAWV0VKWtgPBgCYaxSZUZXWL fQ== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 35h9fks8ky-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 19 Dec 2020 19:28:33 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BJJLTnW186388; Sat, 19 Dec 2020 19:28:32 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 35h7j9f367-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 19 Dec 2020 19:28:32 +0000 Original-Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0BJJSV2E020833; Sat, 19 Dec 2020 19:28:32 GMT In-Reply-To: <<83a6u9tyh1.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5071.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9839 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 malwarescore=0 bulkscore=0 adultscore=0 spamscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012190144 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9839 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 adultscore=0 clxscore=1011 spamscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012190144 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196422 Archived-At: > > The confusion is from the doc not saying explicitly > > that each element of SPECS is a face spec, and NOT a > > face. >=20 > SPECS has no "elements". SPECS stands for arguments to the function > beyond the 1st arg FACE. As with any &rest, you supply zero or more actual args that correspond to SPECS. The function itself receives a single list argument that corresponds to SPECS. In the function body, variable SPECS is a list. And as the doc says, "Each list element...". > Each such argument is either a face name or > a list of attribute/value pairs. AFAICT, the function doesn't work if such an arg is a face name. See what I said about that previously, please. > I changed the doc string to be more clear about that. Great. Thanks for taking a look. Please check for the behavior bug I pointed to: If the doc is correct then the behavior seems bugged. It's not true that you can pass face names, AFAICT. > > 2. "why you thought the argument could be a list of > > one or more faces?" > > > > The doc string explicitly says that elements of > > SPECS can be face names: > > > > Each list element should be either a face name or... >=20 > That's after it says that you should consider SPECS as "forming" a > list of elements. "Forming" a list of elements is unclear, as I said. And SPECS is, itself, from the point of view of the function, a list of elements. See above. There is _nothing_ special about this. Every &rest parameter behaves the same in this regard. BTW, the exact same misleading and inexact text is used for function `face-map-add-relative'. For functions `buffer-face-(set|toggle)', however, we instead say, as we usually do, "Each argument in SPECS should be a face, i.e., either a face name or a property list...". And we explicitly speak of SPECS as a list (singular): "if SPECS is omitted or nil..."