From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#5475: Archives with filenames with square brackets Date: Sun, 31 Jan 2010 20:04:03 +0200 Message-ID: <838wbei224.fsf@gnu.org> References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> <87vden4h9x.fsf@stupidchicken.com> <83ljfj4fje.fsf@gnu.org> <87r5pavvrm.fsf@stupidchicken.com> <838wbiszy7.fsf@gnu.org> <87y6jfcg8b.fsf@mail.jurta.org> <83d40qj4av.fsf@gnu.org> <87aavua6gb.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1264962521 13220 80.91.229.12 (31 Jan 2010 18:28:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 31 Jan 2010 18:28:41 +0000 (UTC) Cc: 5475@debbugs.gnu.org, cyd@stupidchicken.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 31 19:28:38 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NbeX8-0001wP-QE for geb-bug-gnu-emacs@m.gmane.org; Sun, 31 Jan 2010 19:28:31 +0100 Original-Received: from localhost ([127.0.0.1]:43183 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NbeX8-0001zA-7v for geb-bug-gnu-emacs@m.gmane.org; Sun, 31 Jan 2010 13:28:30 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NbeW6-0001MW-Ix for bug-gnu-emacs@gnu.org; Sun, 31 Jan 2010 13:27:26 -0500 Original-Received: from [199.232.76.173] (port=41937 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NbeW6-0001MG-4V for bug-gnu-emacs@gnu.org; Sun, 31 Jan 2010 13:27:26 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NbeW3-0004iZ-3P for bug-gnu-emacs@gnu.org; Sun, 31 Jan 2010 13:27:26 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45125) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NbeW2-0004iF-AS for bug-gnu-emacs@gnu.org; Sun, 31 Jan 2010 13:27:22 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NbeAQ-0001Ry-7N; Sun, 31 Jan 2010 13:05:02 -0500 X-Loop: bug-gnu-emacs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 Jan 2010 18:05:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5475 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5475-submit@debbugs.gnu.org id=B5475.12649610775547 (code B ref 5475); Sun, 31 Jan 2010 18:05:02 +0000 Original-Received: (at 5475) by debbugs.gnu.org; 31 Jan 2010 18:04:37 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nbe9z-0001RP-VN for submit@debbugs.gnu.org; Sun, 31 Jan 2010 13:04:36 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nbe9w-0001RC-QD for 5475@debbugs.gnu.org; Sun, 31 Jan 2010 13:04:33 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KX400H00HX3BV00@a-mtaout22.012.net.il> for 5475@debbugs.gnu.org; Sun, 31 Jan 2010 20:04:06 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.70.32.75]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KX4006DHI6OOZP0@a-mtaout22.012.net.il>; Sun, 31 Jan 2010 20:04:05 +0200 (IST) In-reply-to: <87aavua6gb.fsf@mail.jurta.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 31 Jan 2010 13:05:02 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34826 Archived-At: > From: Juri Linkov > Cc: cyd@stupidchicken.com, 5475@debbugs.gnu.org > Date: Sun, 31 Jan 2010 12:56:19 +0200 > > >> The default value of `archive-zip-extract' can be either "unzip" or > >> "pkunzip" (depending on the presence of the executable in `exec-path'), > >> but the function `archive-zip-extract' compares with the value "pkzip". > >> So the pkzip/pkunzip branch is never executed. > >> > >> It seems the intention of the change revno#45347 (2002-05-19) was > >> to compare with "pkunzip" instead of "pkzip" > > > > Right, looks like a bug. > > > > Btw, I looked into 7z, and it doesn't have the same problem as unzip. > > So we probably should only quote with unzip. > > Does the following patch look right? At least, it fixes a bug, and > after feature freeze we could add more data structures to defcustom to > indicate whether the file name needs to be quoted. Looks okay to me, except that perhaps compare strings case-insensitively instead of just with `equal'.