From: Eli Zaretskii <eliz@gnu.org>
To: Chong Yidong <cyd@gnu.org>
Cc: lekktu@gmail.com, jwalt@garni.ch, 12463@debbugs.gnu.org
Subject: bug#12463: 24.2; pos-visible-in-window-p gets slower over time
Date: Fri, 21 Sep 2012 20:03:34 +0300 [thread overview]
Message-ID: <838vc3xq8p.fsf@gnu.org> (raw)
In-Reply-To: <87r4pvitjk.fsf@gnu.org>
> From: Chong Yidong <cyd@gnu.org>
> Date: Fri, 21 Sep 2012 18:01:19 +0800
> Cc: Jörg Walter <jwalt@garni.ch>, 12463@debbugs.gnu.org
>
> Thanks. Fixed in the attached patch, which also addresses Eli's other
> comments. Please take a look again.
Thanks.
> /* Define a new image type from TYPE. This adds a copy of TYPE to
> ! image_types and caches the loading status of TYPE.
>
> ! LIBRARIES is an alist associating dynamic libraries to external
> ! files implementing them, which is passed to the image library
> ! initialization function if necessary. A nil value defaults to
> ! Vdynamic_library_alist. */
> !
> ! static struct image_type *
> ! define_image_type (struct image_type *type, Lisp_Object libraries)
> {
> ! struct image_type *p = NULL;
> ! Lisp_Object target_type = *type->type;
> ! int type_valid = 1;
>
> ! for (p = image_types; p; p = p->next)
> ! if (EQ (*p->type, target_type))
> ! return p;
> !
> ! if (type->init)
> {
> ! #ifdef HAVE_NTGUI
> ! /* If we failed to load the library before, don't try again. */
> ! Lisp_Object tested = Fassq (target_type, Vlibrary_cache);
> ! if (CONSP (tested) && NILP (XCDR (tested)))
> ! type_valid = 0;
> ! else
> ! #endif
> ! {
> ! /* If the load failed, avoid trying again. */
> ! type_valid = (*type->init)(libraries);
> ! CACHE_IMAGE_TYPE (target_type, type_valid);
> ! }
> ! }
>
> + if (type_valid)
> + {
> /* Make a copy of TYPE to avoid a bus error in a dumped Emacs.
> The initialized data segment is read-only. */
> p = xmalloc (sizeof *p);
> *p = *type;
> p->next = image_types;
> image_types = p;
> }
>
> ! return p;
> }
Am I missing something, or will this really call the initialization
function again and again and again? AFAIU, if an image's library is
already in Vlibrary_cache, and the cdr of its association is non-nil,
that means the initialization function was already called for the
corresponding image type, and it returned non-zero. So there's no
need to call it again.
next prev parent reply other threads:[~2012-09-21 17:03 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 23:51 bug#12463: 24.2; pos-visible-in-window-p gets slower over time Jörg Walter
2012-09-18 7:46 ` Eli Zaretskii
2012-09-18 9:46 ` Jörg Walter
2012-09-18 10:23 ` Eli Zaretskii
2012-09-18 15:05 ` Matt Lundin
2012-09-18 16:24 ` Eli Zaretskii
2012-09-18 15:17 ` Chong Yidong
2012-09-18 16:18 ` Jörg Walter
2012-09-20 23:22 ` Juanma Barranquero
2012-09-21 3:52 ` Chong Yidong
2012-09-21 5:42 ` Chong Yidong
2012-09-21 7:34 ` Eli Zaretskii
2012-09-21 9:24 ` Chong Yidong
2012-09-21 10:47 ` Juanma Barranquero
2012-09-21 12:33 ` Eli Zaretskii
2012-09-21 16:38 ` Stefan Monnier
2012-09-21 16:58 ` Eli Zaretskii
2012-09-21 20:34 ` Stefan Monnier
2012-09-22 6:58 ` Eli Zaretskii
2012-09-22 20:20 ` Stefan Monnier
2012-09-22 20:31 ` Juanma Barranquero
2012-09-23 9:17 ` Chong Yidong
2012-09-23 3:50 ` Eli Zaretskii
2012-09-21 9:10 ` Juanma Barranquero
2012-09-21 10:01 ` Chong Yidong
2012-09-21 17:03 ` Eli Zaretskii [this message]
2012-09-21 17:07 ` Juanma Barranquero
2012-09-21 17:45 ` Eli Zaretskii
2012-09-22 1:23 ` Chong Yidong
2012-09-22 8:36 ` Eli Zaretskii
2012-09-22 11:05 ` Chong Yidong
2012-09-22 11:18 ` Eli Zaretskii
2012-09-22 14:14 ` Chong Yidong
2012-09-22 14:25 ` Eli Zaretskii
2012-09-22 19:20 ` Juanma Barranquero
2012-09-22 19:46 ` Eli Zaretskii
2012-09-22 19:53 ` Juanma Barranquero
2012-09-23 3:48 ` Eli Zaretskii
2012-09-21 6:58 ` Eli Zaretskii
2012-09-21 8:36 ` Juanma Barranquero
2012-09-21 9:11 ` Chong Yidong
2012-09-21 9:17 ` Juanma Barranquero
2012-09-18 16:19 ` Eli Zaretskii
2012-09-18 16:26 ` Jörg Walter
2012-09-18 17:19 ` Eli Zaretskii
2012-09-18 17:31 ` Juanma Barranquero
2012-09-18 20:00 ` Eli Zaretskii
2012-09-19 2:31 ` Juanma Barranquero
2012-09-19 2:57 ` Eli Zaretskii
2012-09-19 3:03 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838vc3xq8p.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=12463@debbugs.gnu.org \
--cc=cyd@gnu.org \
--cc=jwalt@garni.ch \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).