From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12829: 24.3.50; emacs_abort () called from w32proc.c:1128 Date: Sat, 17 Nov 2012 17:40:51 +0200 Message-ID: <838va02q64.fsf@gnu.org> References: <509E96E4.1080702@optusnet.com.au> <831ufs4sff.fsf@gnu.org> <50A7AEDA.8060801@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1353166939 26927 80.91.229.3 (17 Nov 2012 15:42:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 17 Nov 2012 15:42:19 +0000 (UTC) Cc: stephen_powell@optusnet.com.au, 12829@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 17 16:42:30 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TZkXM-00055z-Fu for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Nov 2012 16:42:28 +0100 Original-Received: from localhost ([::1]:33502 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZkXC-0008R0-Af for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Nov 2012 10:42:18 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:44742) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZkX7-0008QO-FQ for bug-gnu-emacs@gnu.org; Sat, 17 Nov 2012 10:42:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TZkX4-0007o5-Cp for bug-gnu-emacs@gnu.org; Sat, 17 Nov 2012 10:42:13 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40768) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZkX4-0007o1-9g for bug-gnu-emacs@gnu.org; Sat, 17 Nov 2012 10:42:10 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TZkXu-0004HP-KW for bug-gnu-emacs@gnu.org; Sat, 17 Nov 2012 10:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Nov 2012 15:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12829 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12829-submit@debbugs.gnu.org id=B12829.135316694116402 (code B ref 12829); Sat, 17 Nov 2012 15:43:02 +0000 Original-Received: (at 12829) by debbugs.gnu.org; 17 Nov 2012 15:42:21 +0000 Original-Received: from localhost ([127.0.0.1]:51019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TZkXF-0004GU-0E for submit@debbugs.gnu.org; Sat, 17 Nov 2012 10:42:21 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:59503) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TZkXA-0004GI-2d for 12829@debbugs.gnu.org; Sat, 17 Nov 2012 10:42:17 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MDN001001R2BZ00@a-mtaout22.012.net.il> for 12829@debbugs.gnu.org; Sat, 17 Nov 2012 17:41:20 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MDN000F428VG2K0@a-mtaout22.012.net.il>; Sat, 17 Nov 2012 17:41:20 +0200 (IST) In-reply-to: <50A7AEDA.8060801@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-Spam-Score: 1.5 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-Spam-Score: 0.7 (/) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:67059 Archived-At: > Date: Sat, 17 Nov 2012 07:35:54 -0800 > From: Paul Eggert > CC: Stephen Powell , > 12829@debbugs.gnu.org > > On 11/16/2012 11:09 PM, Eli Zaretskii wrote: > > Any news? Should I commit the changes? > > I don't see anything about it that would break things, > though I'm looking only at the non-Windows part. Thanks, I will install in a short while. > The following change to wait_for_termination_1 > would be simpler, assuming the Windows waitpid emulation > is good enough now. > > === modified file 'src/sysdep.c' > --- src/sysdep.c 2012-11-14 04:55:41 +0000 > +++ src/sysdep.c 2012-11-17 15:33:25 +0000 > @@ -289,10 +289,6 @@ wait_for_termination_1 (pid_t pid, int i > { > while (1) > { > -#ifdef WINDOWSNT > - wait (0); > - break; > -#else /* not WINDOWSNT */ > int status; > int wait_result = waitpid (pid, &status, 0); > if (wait_result < 0) > @@ -306,7 +302,6 @@ wait_for_termination_1 (pid_t pid, int i > break; > } > > -#endif /* not WINDOWSNT */ > if (interruptible) > QUIT; > } Yes, I plan to do that, given the discussion about the "interruptible" wait here. The Windows emulation actually calls QUIT internally, instead of returning with EINTR, but I don't think that matters in this case.