From: Eli Zaretskii <eliz@gnu.org>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: 17115-done@debbugs.gnu.org
Subject: bug#17115: 24.3.50; possible bug in drawing images with box on W32
Date: Fri, 28 Mar 2014 10:25:03 +0300 [thread overview]
Message-ID: <838uruyecw.fsf@gnu.org> (raw)
In-Reply-To: <wlzjkbw3aa.wl%mituharu@math.s.chiba-u.ac.jp>
> Date: Fri, 28 Mar 2014 09:54:53 +0900
> From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
> Cc: 17115-done@debbugs.gnu.org
>
> > Thanks, I installed this with minor changes (to keep the original
> > code style intact).
>
> I moved the variables `x' and `y' to the inner block because that
> makes the code look more like the corresponding one in xterm.c.
I don't object that in principle, I just think that style-related
changes like this should be separate from the other changes, because
otherwise they make it harder to understand what exactly was changed,
and why.
prev parent reply other threads:[~2014-03-28 7:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 2:42 bug#17115: 24.3.50; possible bug in drawing images with box on W32 YAMAMOTO Mitsuharu
2014-03-27 4:48 ` YAMAMOTO Mitsuharu
2014-03-27 16:29 ` Eli Zaretskii
2014-03-28 0:54 ` YAMAMOTO Mitsuharu
2014-03-28 7:25 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838uruyecw.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=17115-done@debbugs.gnu.org \
--cc=mituharu@math.s.chiba-u.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).