unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 17146-done@debbugs.gnu.org, nbtrap@nbtrap.com
Subject: bug#17146: 24.4.50; File save with incapable coding system precluded by strange error	message
Date: Mon, 05 May 2014 09:20:51 +0300	[thread overview]
Message-ID: <838uqgzqyk.fsf@gnu.org> (raw)
In-Reply-To: <cc38b3c0-fde5-4c21-8f39-a3ef9d99984c@default>

> Date: Sun, 4 May 2014 19:01:34 -0700 (PDT)
> From: Drew Adams <drew.adams@oracle.com>
> Cc: nbtrap@nbtrap.com, 17146@debbugs.gnu.org
> 
> > > > This change is backward-incompatible, but is not in NEWS for some
> > > > reason.  Needless to say, the canonical way of fixing the fallout is
> > > > not described in NEWS.  Are functions that need Help mode supposed to
> > > > let-bind these hooks?  If so, the patch below should fix the problem.
> > > > In any case, please document the change and the way to adapt to it in
> > > > NEWS.
> > >
> > > Please see bug #17109.  FWIW, this regression really bothers me.
> > 
> > I read the mailing list, so I'm perfectly aware of that bug and the
> > related discussions.  Please don't hijack this bug to hold it hostage
> > to that one.  This bug is about a related issue, but one thing it is
> > _not_ about is reverting the change in question.  So talking here
> > instead of on #17109 is not useful.
> 
> It is now two months later, the 24.4 pretest is out, and there still
> has been no follow-up for this "related-issue" bug - or for #17109,
> for that matter.  I was hoping to get some guidance from the fix for
> #17146, at least.

#17146 (this bug) is no longer present in the current pretest.  So I'm
going to mark this bug "done".

> I am still left wondering (a) whether there is an intention
> to fix what has been broken for Emacs 24.4, and (b) if not, how
> I will need to go about fixing the damage myself locally.
> 
> See also bug #17397, which I filed recently.  Help commands
> (seemingly because they now use only `with-help-window') no longer
> invoke `temp-buffer-show-hook', and this breaks quite a bit for me
> (whether I use one of my own help commands or a vanilla one).
> 
> The Lisp manual has still not been updated to reflect all of the
> changes, AFAICT.  It still says clearly, for instance, that
> `with-output-to-temp-buffer' switches to Help mode, which it
> does *not* (bug #17109):
> 
>   "Unlike `with-output-to-temp-buffer', however, it
>    [`with-temp-buffer-window'] does not automatically switch
>    that buffer to Help mode."
> 
> And this text was updated for release 24.4 to add the word
> "automatically", so presumably someone also paid some attention
> to its continued claim regarding `with-output-to-temp-buffer'.

This part of the discussion should probably be elsewhere, maybe in
#17109, maybe in a separate bug report (with new details about the
signs of damage you see in your code).





  reply	other threads:[~2014-05-05  6:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <<87ha6fyw1e.fsf@nbtrap.com>
     [not found] ` <<83lhvqcsb3.fsf@gnu.org>
     [not found]   ` <<aa071e4a-793d-4035-9d7e-04c07955b130@default>
     [not found]     ` <<83ha6ecqj3.fsf@gnu.org>
2014-05-05  2:01       ` bug#17146: 24.4.50; File save with incapable coding system precluded by strange error message Drew Adams
2014-05-05  6:20         ` Eli Zaretskii [this message]
2014-03-31  1:52 Nathan Trapuzzano
2014-03-31 15:16 ` Eli Zaretskii
2014-03-31 15:30   ` Drew Adams
2014-03-31 15:54     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838uqgzqyk.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=17146-done@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    --cc=nbtrap@nbtrap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).