From: Eli Zaretskii <eliz@gnu.org>
To: rrt@sc3d.org
Cc: 18238@debbugs.gnu.org
Subject: bug#18238: Fix for DOS build when using more accurate config[.h].in
Date: Sun, 10 Aug 2014 22:35:58 +0300 [thread overview]
Message-ID: <838umwjfxd.fsf@gnu.org> (raw)
In-Reply-To: <83ha1kjj1p.fsf@gnu.org>
> Date: Sun, 10 Aug 2014 21:28:34 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 18238@debbugs.gnu.org
>
> > Date: Sun, 10 Aug 2014 19:20:48 +0100
> > From: Reuben Thomas <rrt@sc3d.org>
> > Cc: 18238@debbugs.gnu.org
> >
> > > I don't see why the suggested code is better than the existing one.
> > > HAVE_GETRLIMIT means more than its name says, as you point out, so
> > > DJGPP is correct in not defining one.
> > >
> >
> > I think I was unclear, sorry: DJGPP does define getrlimit. It is only the
> > MSDOS config.in that says it is not defined. If you run ./configure, then
> > it detects getrlimit, and defines HAVE_GETRLIMIT.
>
> Then it's a bug in the configure test for getrlimit: it should not
> only test for the existence of the function, but also for RLIMIT_AS
> and RLIMIT_DATA it actually needs.
Alternatively, you could leave the configure test alone, and instead
test for RLIMIT_* constants in the conditional, like this:
#if defined HAVE_GETRLIMIT && defined RLIMIT_DATA && defined RLIMIT_AS
...
etc. This is what emacs.c does with HAVE_SETRLIMIT.
next prev parent reply other threads:[~2014-08-10 19:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-10 16:47 bug#18238: Fix for DOS build when using more accurate config[.h].in Reuben Thomas
2014-08-10 16:52 ` Andreas Schwab
2014-08-10 16:53 ` Reuben Thomas
2014-08-10 17:59 ` Stefan Monnier
2014-08-10 18:05 ` Eli Zaretskii
2014-08-10 18:20 ` Reuben Thomas
2014-08-10 18:28 ` Eli Zaretskii
2014-08-10 19:35 ` Eli Zaretskii [this message]
2021-10-22 19:02 ` Stefan Kangas
2021-10-22 21:14 ` Reuben Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-23 6:18 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838umwjfxd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=18238@debbugs.gnu.org \
--cc=rrt@sc3d.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).