unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Pip Cet <pipcet@gmail.com>
Cc: 21394-done@debbugs.gnu.org
Subject: bug#21394: 25.0.50; Segfault when displaying unprintable character in echo area while frames are being created
Date: Sat, 05 Sep 2015 11:12:09 +0300	[thread overview]
Message-ID: <838u8l8eue.fsf@gnu.org> (raw)
In-Reply-To: <CAOqdjBcLFNbk-B0XY2mUNMb+tzfpUbHQxdYz9+jxB=ti0o=6Kg@mail.gmail.com>

> Date: Wed, 2 Sep 2015 16:08:08 +0000
> From: Pip Cet <pipcet@gmail.com>
> Cc: 21394@debbugs.gnu.org
> 
> On Wed, Sep 2, 2015 at 3:16 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>     > This patch appears, so far, to run without a segfault
>     
> No segfault overnight.
> 
>     Can you please verify that when the (unmodified) code does segfault,
>     the offending face ID is indeed stored in
>     last_escape_glyph_merged_face_id? I'd like to be sure we have really
>     found the source of that face ID.
> 
> It is, indeed, and last_escape_glyph_frame also equals it->f.
> 
> Revised patch attached.

Thanks, I pushed it with a few minor changes.

I'm closing this bug.  feel free to reopen if something else emerges
that needs to be taken care of.





      reply	other threads:[~2015-09-05  8:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-01 16:43 bug#21394: 25.0.50; Segfault when displaying unprintable character in echo area while frames are being created Pip Cet
2015-09-01 16:57 ` Eli Zaretskii
2015-09-01 17:30   ` Pip Cet
     [not found]     ` <CAOqdjBd7MN39Ra_3nnGCFQAb=xhv7AZt5f+rvAKqqYtoCQKTqQ@mail.gmail.com>
2015-09-01 18:08       ` Eli Zaretskii
2015-09-01 18:52         ` Pip Cet
2015-09-01 19:37           ` Eli Zaretskii
2015-09-01 20:19             ` Pip Cet
2015-09-02 15:16               ` Eli Zaretskii
2015-09-02 16:08                 ` Pip Cet
2015-09-05  8:12                   ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838u8l8eue.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=21394-done@debbugs.gnu.org \
    --cc=pipcet@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).