From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 21824@debbugs.gnu.org
Subject: bug#21824: 25.0.50; overlay modification-hooks called with wrong buffer
Date: Sat, 07 Nov 2015 10:28:32 +0200 [thread overview]
Message-ID: <838u6aqklr.fsf@gnu.org> (raw)
In-Reply-To: <CAM-tV-9UDXdVu_+akY5RxW2cY9gFo7N8wwo+djhaRsBRK28W3Q@mail.gmail.com>
> Date: Fri, 6 Nov 2015 21:24:50 -0500
> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Cc: 21824-done@debbugs.gnu.org
>
> On Fri, Nov 6, 2015 at 10:23 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> >
> > Please see if the original bug is solved by the latest master.
>
> Yes, it's fixed.
Thanks for testing.
> > Btw, any idea how come overlays wound up in *Messages* in the original
> > scenario?
>
> global-highlight-parentheses-mode puts overlays in every buffer.
Does it really mean to do that in *Messages*? If not, perhaps we
should suggest to the developers of highlight-parentheses to exempt
*Messages* from that, as that buffer is pretty specialized anyway. In
particular, due to the way the message logging in *Messages* is
implemented, the overlay modification hooks will only ever be called
in that buffer with AFTER non-nil, and even that will only happen when
Emacs decides to delete some text from *Messages*; inserting a new
message there will never call the overlay modification hooks.
> > Actually, would you like converting your test case into a test, and
> > post a patch to the test suite to that effect? TIA.
>
> Something like this? I'm not sure where to put it.
Yes, this looks good to me. How about creating a new file
buffer-tests.el (the offending code is in buffer.c)?
Thanks.
next prev parent reply other threads:[~2015-11-07 8:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 3:06 bug#21824: 25.0.50; overlay modification-hooks called with wrong buffer Noam Postavsky
2015-11-04 15:31 ` Eli Zaretskii
2015-11-05 0:19 ` Noam Postavsky
2015-11-05 3:33 ` Noam Postavsky
2015-11-05 16:09 ` Eli Zaretskii
2015-11-06 3:14 ` Noam Postavsky
2015-11-06 15:23 ` Eli Zaretskii
2015-11-06 15:37 ` Eli Zaretskii
2015-11-07 2:24 ` Noam Postavsky
2015-11-07 8:28 ` Eli Zaretskii [this message]
2015-11-07 16:22 ` Noam Postavsky
2015-11-07 18:07 ` Eli Zaretskii
2015-11-08 1:43 ` Noam Postavsky
2015-11-08 3:41 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838u6aqklr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=21824@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).