From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22534: File notify broken on Windows Date: Thu, 04 Feb 2016 20:47:02 +0200 Message-ID: <838u30wbx5.fsf@gnu.org> References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1454611706 13720 80.91.229.3 (4 Feb 2016 18:48:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 4 Feb 2016 18:48:26 +0000 (UTC) Cc: 22534@debbugs.gnu.org, michael.albinus@gmx.de To: Fabrice Popineau Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 04 19:48:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aROwr-0007Fp-VJ for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Feb 2016 19:48:10 +0100 Original-Received: from localhost ([::1]:43571 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aROwr-0004AW-7p for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Feb 2016 13:48:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51505) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aROwo-0004AP-0w for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2016 13:48:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aROwk-0002QR-04 for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2016 13:48:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aROwj-0002QN-SO for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2016 13:48:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aROwj-0008DE-N8 for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2016 13:48:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Feb 2016 18:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145461164931531 (code B ref 22534); Thu, 04 Feb 2016 18:48:01 +0000 Original-Received: (at 22534) by debbugs.gnu.org; 4 Feb 2016 18:47:29 +0000 Original-Received: from localhost ([127.0.0.1]:60615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aROwD-0008CU-BZ for submit@debbugs.gnu.org; Thu, 04 Feb 2016 13:47:29 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:60486) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aROwB-0008CG-NG for 22534@debbugs.gnu.org; Thu, 04 Feb 2016 13:47:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aROw2-0002LU-Ot for 22534@debbugs.gnu.org; Thu, 04 Feb 2016 13:47:22 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35612) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aROw2-0002LQ-LM; Thu, 04 Feb 2016 13:47:18 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4494 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aROw1-000473-R4; Thu, 04 Feb 2016 13:47:18 -0500 In-reply-to: (message from Fabrice Popineau on Thu, 4 Feb 2016 10:49:42 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:112426 Archived-At: > From: Fabrice Popineau > Date: Thu, 4 Feb 2016 10:49:42 +0100 > Cc: Eli Zaretskii , 22534@debbugs.gnu.org > > - notifications returned are not the same whether you run the tests in batch mode or interactive mode. > In interactive mode, there is a deleted notification which is sent when your remove the directory being > watched. > This event is not seen when running in batch mode (make check). I wonder what could make a difference. Support for file notifications in batch mode is fragile: w32notify normally works by sending a message to the main thread whenever it has a notification to report. But in batch mode, the main thread doesn't read Windows messages, so whether an event gets reported depends on whether 'pselect' is called, which depends on what API is called to wait for notifications and read them. > - in the test file-notify-test06-many-events to check that events > are not dropped : I have to lower the 1000 number. The test fails > as soon as I go higher than around 260. Is there some limit here ? Is this in interactive or a batch-mode run? > Once the limit is reached, only the first notification is returned. What do you mean by "the first notification"? AFAIU, the 1000 events are generated as 500 pairs of renames, so what is "the first" here, after 260 were already generated? > Overall, I don't think anymore that the patch by Michael has broken w32 file notifications > but rather that the new tests have highlighted some potential problems with it. I've just found a serious problem, see bug#22557. I'm not sure it is related to what you see here, but IMO until that bug is resolved, there's no sense in trying to analyze what happens with notifications on MS-Windows.