From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23179: 25.0.92; Restore `M-,' to continue etags search Date: Sun, 03 Apr 2016 22:36:07 +0300 Message-ID: <838u0upjrs.fsf@gnu.org> References: <48066d7c-e4d3-acf5-fdcf-1aa9a108cb90@yandex.ru> <83bn5ttwul.fsf@gnu.org> <83shz4sdi0.fsf@gnu.org> <5a9b5719-ea84-89bc-c0c5-37692fafd23d@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1459712242 26926 80.91.229.3 (3 Apr 2016 19:37:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 3 Apr 2016 19:37:22 +0000 (UTC) Cc: 23179@debbugs.gnu.org, dgutov@yandex.ru To: Anders Lindgren Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 03 21:37:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1amnpd-0006ct-DW for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Apr 2016 21:37:09 +0200 Original-Received: from localhost ([::1]:54984 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amnpc-00024T-UC for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Apr 2016 15:37:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56225) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amnpX-00020j-SJ for bug-gnu-emacs@gnu.org; Sun, 03 Apr 2016 15:37:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amnpW-0008AR-Ko for bug-gnu-emacs@gnu.org; Sun, 03 Apr 2016 15:37:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53182) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amnpW-0008AG-Gy for bug-gnu-emacs@gnu.org; Sun, 03 Apr 2016 15:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1amnpW-0008HJ-Cp for bug-gnu-emacs@gnu.org; Sun, 03 Apr 2016 15:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Apr 2016 19:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23179-submit@debbugs.gnu.org id=B23179.145971220531800 (code B ref 23179); Sun, 03 Apr 2016 19:37:02 +0000 Original-Received: (at 23179) by debbugs.gnu.org; 3 Apr 2016 19:36:45 +0000 Original-Received: from localhost ([127.0.0.1]:50309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amnpF-0008Gp-Gl for submit@debbugs.gnu.org; Sun, 03 Apr 2016 15:36:45 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amnpD-0008Gd-Pi for 23179@debbugs.gnu.org; Sun, 03 Apr 2016 15:36:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amnp5-0007iA-KN for 23179@debbugs.gnu.org; Sun, 03 Apr 2016 15:36:38 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58207) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amnp5-0007hz-Gr; Sun, 03 Apr 2016 15:36:35 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3946 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1amnp4-00007E-J3; Sun, 03 Apr 2016 15:36:35 -0400 In-reply-to: (message from Anders Lindgren on Sun, 3 Apr 2016 20:32:17 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115979 Archived-At: > Date: Sun, 3 Apr 2016 20:32:17 +0200 > From: Anders Lindgren > Cc: Eli Zaretskii , 23179@debbugs.gnu.org > > * Unlike `tags-search', it search through all source files before presenting the first match. The traditional > `tags-search' stop of the first match, and continue searching when the used pressed `M-,'. The effect is that it > becomes much, much slower to find the first match [+++]. I would suggest that xref should provide two kinds > of searches: one incremental (like `tags-search') and one `find-all' (like the provided function). You could think > of `isearch' vs. `occur'. It would be fine with me if `next-error' would be used to restart the incremental search > (even though I would probably bind it to `M-,'). OTOH, seeing all of the hits allows you to find the one(s) you are looking for much faster, since you don't need to visit them one by one. Another nice side effect is that you don't end up visiting all of the files you needed to look through until you find the hit(s) you were really looking for. So this change has upsides as well, not only downsides. I agree that IWBNI there was an incremental version, although I'm not sure I'd like it to bring me one hit at a time, I'd rather see a larger chunk. > * There is no need for a xref UI window when doing an incremental search or query-replace. It just occupies > precious screen real estate. The UI window is the one that allows you to jump to the hit you are looking for quickly. > * The xref UI window is not updated to reflect the current location. For example, in a *grep* buffer, the cursor > move and an arrow in the left fringe reflect the current location. The cursor does move in the xref buffer if you use 'n' and 'p' in that buffer. > * I like the touch that the matches in the *xref* buffer are syntax highlighted. Unfortunately, not all matches are > highlighted. It appears as though only matches in previously viewed parts of source files retain syntax > highlighting. I cannot reproduce this. > * `next-error' in ChangeLog buffers cause Emacs to go to the corresponding change. This makes it hard to > step past irrelevant xref matches if they occur a ChangeLog file. You are supposed to get past them by moving in the xref buffer instead. > +++ Using "etags *.h *.m *.c" in the Emacs "src" directory, `(tags-search "nstrace")' find the first occurrence > in 0.7 seconds, whereas the new `tags-find-regexp' takes over 8 seconds to perform a full search. But after those 0.7 sec you are blind: you don't know how many hits are there, and what will be the next hit to be shown to you.