From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24206: 25.1; Curly quotes generate invalid strings, leading to a segfault Date: Tue, 16 Aug 2016 21:31:40 +0300 Message-ID: <838tvwftv7.fsf@gnu.org> References: <8337m7h1dp.fsf@gnu.org> <83zioffew5.fsf@gnu.org> <83popaf1yz.fsf@gnu.org> <87bn0u3rqc.fsf@linux-m68k.org> <83mvkdg91i.fsf@gnu.org> <8b78f23f-4a4f-e568-b760-3350ca7bb8d3@cs.ucla.edu> <83eg5og4n9.fsf@gnu.org> <17f39e7e-31d1-62e5-367d-833b957a39e3@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1471372400 9034 195.159.176.226 (16 Aug 2016 18:33:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 16 Aug 2016 18:33:20 +0000 (UTC) Cc: p.stephani2@gmail.com, johnw@gnu.org, schwab@linux-m68k.org, nicolas@petton.fr, 24206@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 16 20:33:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZjAo-00023P-WD for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Aug 2016 20:33:15 +0200 Original-Received: from localhost ([::1]:43565 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZjAm-0008NO-5f for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Aug 2016 14:33:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZjAg-0008NJ-8X for bug-gnu-emacs@gnu.org; Tue, 16 Aug 2016 14:33:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZjAb-0004N1-Vz for bug-gnu-emacs@gnu.org; Tue, 16 Aug 2016 14:33:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33533) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZjAb-0004Mx-SW for bug-gnu-emacs@gnu.org; Tue, 16 Aug 2016 14:33:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bZjAb-0005hQ-Lr for bug-gnu-emacs@gnu.org; Tue, 16 Aug 2016 14:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Aug 2016 18:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24206 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24206-submit@debbugs.gnu.org id=B24206.147137233521855 (code B ref 24206); Tue, 16 Aug 2016 18:33:01 +0000 Original-Received: (at 24206) by debbugs.gnu.org; 16 Aug 2016 18:32:15 +0000 Original-Received: from localhost ([127.0.0.1]:59478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZj9r-0005gQ-5Y for submit@debbugs.gnu.org; Tue, 16 Aug 2016 14:32:15 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZj9q-0005gE-1P for 24206@debbugs.gnu.org; Tue, 16 Aug 2016 14:32:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZj9j-0004HY-Tw for 24206@debbugs.gnu.org; Tue, 16 Aug 2016 14:32:08 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55625) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZj9g-0004Gu-1n; Tue, 16 Aug 2016 14:32:04 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4762 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bZj9b-0006cb-T7; Tue, 16 Aug 2016 14:32:02 -0400 In-reply-to: <17f39e7e-31d1-62e5-367d-833b957a39e3@cs.ucla.edu> (message from Paul Eggert on Tue, 16 Aug 2016 10:37:39 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122285 Archived-At: > Cc: schwab@linux-m68k.org, p.stephani2@gmail.com, johnw@gnu.org, > nicolas@petton.fr, 24206@debbugs.gnu.org > From: Paul Eggert > Date: Tue, 16 Aug 2016 10:37:39 -0700 > > Let's not cut the RC now, as unfortunately that patch fails spectacularly. (I > didn't test it yesterday; I tested your other patch, which is obviously better.) > To reproduce the problem, run emacs -Q and "C-h f car RET"; Emacs will display > "Wrong type argument: integer-or-marker-p, nil" instead of help. Thanks, that blunder should be fixed now. > The attached patch to emacs-25 fixes the problem. It makes the code functionally > equivalent to the other of the 2 patches that you posted yesterday, and is > simpler. OK to install in emacs-25? Sorry, no. I don't want to indiscriminately convert unibyte strings to multibyte in substitute-command-keys.