From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24935: [PATCH] Add tests for rot13.el Date: Tue, 15 Nov 2016 22:23:32 +0200 Message-ID: <838tskh4qj.fsf@gnu.org> References: <1479035256.4382.0@smtp.gmail.com> <1479035256.4382.0@smtp.gmail.com> <1479235435.2503.2@smtp.gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1479241466 2129 195.159.176.226 (15 Nov 2016 20:24:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 15 Nov 2016 20:24:26 +0000 (UTC) Cc: 24935@debbugs.gnu.org To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 15 21:24:21 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6kH4-0007Ca-JP for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Nov 2016 21:24:10 +0100 Original-Received: from localhost ([::1]:48642 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6kH7-0004dr-MY for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Nov 2016 15:24:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6kH1-0004dl-J9 for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2016 15:24:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6kGw-0008Qt-Ey for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2016 15:24:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43128) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c6kGw-0008Q8-Bt for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2016 15:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c6kGv-00026t-UQ for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2016 15:24:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Nov 2016 20:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24935-submit@debbugs.gnu.org id=B24935.14792414288089 (code B ref 24935); Tue, 15 Nov 2016 20:24:01 +0000 Original-Received: (at 24935) by debbugs.gnu.org; 15 Nov 2016 20:23:48 +0000 Original-Received: from localhost ([127.0.0.1]:58525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6kGh-00026O-Qc for submit@debbugs.gnu.org; Tue, 15 Nov 2016 15:23:48 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:49842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6kGg-00026A-JN for 24935@debbugs.gnu.org; Tue, 15 Nov 2016 15:23:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6kGW-0008J7-IA for 24935@debbugs.gnu.org; Tue, 15 Nov 2016 15:23:41 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35588) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6kGW-0008J2-ER; Tue, 15 Nov 2016 15:23:36 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3511 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c6kGV-0001Nn-Qy; Tue, 15 Nov 2016 15:23:36 -0500 In-reply-to: <1479235435.2503.2@smtp.gmail.com> (message from Simen =?UTF-8?Q?Heggest=C3=B8yl?= on Tue, 15 Nov 2016 19:43:55 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125732 Archived-At: > Date: Tue, 15 Nov 2016 19:43:55 +0100 > From: Simen Heggestøyl > Cc: 24935@debbugs.gnu.org > > "ROT13 encrypt OBJECT, a buffer or string. > Return the ROT13 encrypted string when OBJECT is a string, > ignoring START and END. ROT13 encrypt the region between > positions START and END when OBJECT is a buffer; all three > arguments are then required." It sounds strange to describe first the use case where the arguments are ignored. I suggest this instead: ROT13 encrypt OBJECT, a buffer or string. If OBJECT is a buffer, encrypt the region between START and END. If OBJECT is a string, encrypt it in its entirety, ignoring START and END, and return the encrypted string.