From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#27272: 25.2; [patch] Fix positional args among keyword args in eldoc. Date: Thu, 08 Jun 2017 18:04:29 +0300 Message-ID: <838tl28qrm.fsf@gnu.org> References: <87poegnnyn.fsf@gmail.com> <83mv9j95in.fsf@gnu.org> <87wp8nbxbj.fsf@gmail.com> <83ink791hy.fsf@gnu.org> <87shjbegwy.fsf@gmail.com> <83fufb8avt.fsf@gnu.org> <87efuuki5b.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1496934319 26018 195.159.176.226 (8 Jun 2017 15:05:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 8 Jun 2017 15:05:19 +0000 (UTC) Cc: 27272@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 08 17:05:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dIyzm-0006O6-GI for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Jun 2017 17:05:10 +0200 Original-Received: from localhost ([::1]:50152 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIyzr-0003li-Rc for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Jun 2017 11:05:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIyzj-0003jg-FI for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2017 11:05:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIyze-00012h-Sq for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2017 11:05:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60806) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dIyze-00012b-Pa for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2017 11:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dIyze-0000Ll-Hc for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2017 11:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Jun 2017 15:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27272 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27272-submit@debbugs.gnu.org id=B27272.14969342821316 (code B ref 27272); Thu, 08 Jun 2017 15:05:02 +0000 Original-Received: (at 27272) by debbugs.gnu.org; 8 Jun 2017 15:04:42 +0000 Original-Received: from localhost ([127.0.0.1]:35250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dIyzJ-0000LA-WC for submit@debbugs.gnu.org; Thu, 08 Jun 2017 11:04:42 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dIyzI-0000Kx-Ac for 27272@debbugs.gnu.org; Thu, 08 Jun 2017 11:04:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIyzA-0000iC-3u for 27272@debbugs.gnu.org; Thu, 08 Jun 2017 11:04:35 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56277) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIyzA-0000hz-15; Thu, 08 Jun 2017 11:04:32 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1241 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dIyz9-0001rx-A3; Thu, 08 Jun 2017 11:04:31 -0400 In-reply-to: <87efuuki5b.fsf@gmail.com> (message from Thierry Volpiatto on Thu, 08 Jun 2017 10:17:36 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133396 Archived-At: > From: Thierry Volpiatto > Cc: 27272@debbugs.gnu.org > Date: Thu, 08 Jun 2017 10:17:36 +0200 > > >> >> Try to move your cursor on the different args with and without patch applied. > >> > > >> > Could you please tell it in English? > >> > >> No I can't sorry. > > > > Then I don't see how I can approve your patch. Maybe you can ask > > someone else to explain the issue. > > Perhaps I have also other things to do than loosing my time on this > mailing list. > > So ignore the patch and consider this bugreport: > > Eldoc is highlighting wrongly positional arguments when they are mixed > with keyword arguments. > > Then if you feel it is a bug, fix it (or not) otherwise close this > bugreport. > > Thanks. > > BTW I am the original author of the code I was trying to patch, nevermind. Oh, my. I feel there's some gigantic misunderstanding here, most probably due to my wording. Sorry about that. Let me try again. Could you please elaborate on the incorrect behavior in the example you provided? You wrote: > (cl-defun foo (prompt lst &key a b c)) > > (foo "prompt: " bar :b 2) > > Try to move your cursor on the different args with and without patch applied. Can you please point out which positional arguments are wrongly highlighted, and in which one of these two lines?