From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31316: Emacs hangs in `font_open_entity' Date: Mon, 30 Apr 2018 18:21:12 +0300 Message-ID: <838t94sot3.fsf@gnu.org> References: <20180430.101308.1102659443644829077.wl@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1525101605 19866 195.159.176.226 (30 Apr 2018 15:20:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 30 Apr 2018 15:20:05 +0000 (UTC) Cc: 31316@debbugs.gnu.org To: Werner LEMBERG Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 30 17:20:01 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDAau-00051T-Qw for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Apr 2018 17:20:00 +0200 Original-Received: from localhost ([::1]:60209 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDAd0-0005Cn-OZ for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Apr 2018 11:22:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDAcu-0005CW-QF for bug-gnu-emacs@gnu.org; Mon, 30 Apr 2018 11:22:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDAcs-0003fC-4n for bug-gnu-emacs@gnu.org; Mon, 30 Apr 2018 11:22:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36243) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fDAcs-0003f0-0M for bug-gnu-emacs@gnu.org; Mon, 30 Apr 2018 11:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fDAcr-0007UX-Qd for bug-gnu-emacs@gnu.org; Mon, 30 Apr 2018 11:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Apr 2018 15:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31316 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31316-submit@debbugs.gnu.org id=B31316.152510170028768 (code B ref 31316); Mon, 30 Apr 2018 15:22:01 +0000 Original-Received: (at 31316) by debbugs.gnu.org; 30 Apr 2018 15:21:40 +0000 Original-Received: from localhost ([127.0.0.1]:44140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDAcW-0007Tw-3O for submit@debbugs.gnu.org; Mon, 30 Apr 2018 11:21:40 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDAcS-0007Th-C3 for 31316@debbugs.gnu.org; Mon, 30 Apr 2018 11:21:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDAcM-0002sI-G9 for 31316@debbugs.gnu.org; Mon, 30 Apr 2018 11:21:31 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37172) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDAcH-0002je-BD; Mon, 30 Apr 2018 11:21:25 -0400 Original-Received: from [176.228.60.248] (port=4471 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fDAcG-0008Vd-Oo; Mon, 30 Apr 2018 11:21:25 -0400 In-reply-to: <20180430.101308.1102659443644829077.wl@gnu.org> (message from Werner LEMBERG on Mon, 30 Apr 2018 10:13:08 +0200 (CEST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145867 Archived-At: > Date: Mon, 30 Apr 2018 10:13:08 +0200 (CEST) > From: Werner LEMBERG > > If I call `emacs -Q' and load the attached file `testchar' with > > C-x RET c gb18030 C-x C-f testchar > > Emacs hangs in `font_open_entity' on my GNU/Linux box: > > for (psize = pixel_size; ; psize++) > { > font_object = driver_list->driver->open (f, entity, psize); > if (NILP (font_object)) > return Qnil; > font = XFONT_OBJECT (font_object); > if (font->average_width > 0 && font->height > 0) > break; > } Does the patch below solve this without introducing any new problems? > Both `average_width' and `height' are always zero for `font' > regardless of `psize'; this effectively makes the above code an > endless loop. What kind of strange font has both of these always zero? diff --git a/src/font.c b/src/font.c index ef3f92b..daa6be0 100644 --- a/src/font.c +++ b/src/font.c @@ -2901,7 +2901,9 @@ font_open_entity (struct frame *f, Lisp_Object entity, int pixel_size) for (psize = pixel_size; ; psize++) { font_object = driver_list->driver->open (f, entity, psize); - if (NILP (font_object)) + if (NILP (font_object) + /* Avoid an infinite loop. */ + || psize > pixel_size + 100) return Qnil; font = XFONT_OBJECT (font_object); if (font->average_width > 0 && font->height > 0)