From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37756: [PATCH] Wrong initialization of fringe bitmap Date: Tue, 15 Oct 2019 12:47:26 +0300 Message-ID: <838spmgx1t.fsf@gnu.org> References: Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="105581"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37756@debbugs.gnu.org To: Carlos Pita Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 15 11:48:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKJR6-000RK4-Be for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Oct 2019 11:48:12 +0200 Original-Received: from localhost ([::1]:38964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKJR5-00019g-7J for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Oct 2019 05:48:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39639) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKJQx-00016q-Nb for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2019 05:48:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKJQw-0002j4-Qj for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2019 05:48:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33941) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKJQw-0002iz-Ni for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2019 05:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKJQw-0002VG-IB for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2019 05:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Oct 2019 09:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37756 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37756-submit@debbugs.gnu.org id=B37756.15711328719603 (code B ref 37756); Tue, 15 Oct 2019 09:48:02 +0000 Original-Received: (at 37756) by debbugs.gnu.org; 15 Oct 2019 09:47:51 +0000 Original-Received: from localhost ([127.0.0.1]:42762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKJQk-0002Uo-Rc for submit@debbugs.gnu.org; Tue, 15 Oct 2019 05:47:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKJQj-0002UZ-SX for 37756@debbugs.gnu.org; Tue, 15 Oct 2019 05:47:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43726) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iKJQd-0002Zm-Bm; Tue, 15 Oct 2019 05:47:43 -0400 Original-Received: from [176.228.60.248] (port=2177 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iKJQa-0003NL-OD; Tue, 15 Oct 2019 05:47:43 -0400 In-reply-to: (message from Carlos Pita on Mon, 14 Oct 2019 23:39:19 -0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169374 Archived-At: > From: Carlos Pita > Date: Mon, 14 Oct 2019 23:39:19 -0300 > > In fringe.c:1606 you have: > > xfb = xmalloc (sizeof fb + fb.height * BYTES_PER_BITMAP_ROW); > fb.bits = b = ((unsigned short *) > ptr_bounds_clip (xfb + 1, fb.height * BYTES_PER_BITMAP_ROW)); > xfb = ptr_bounds_clip (xfb, sizeof *xfb); > memset (b, 0, fb.height); > > I might be wrong but it seems to me that the last line should be: > > memset (b, 0, fb.height * BYTES_PER_BITMAP_ROW); > > instead. Can you explain your reasoning? The loop after that does initialize the structure as needed, doesn't it?