From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Thu, 17 Oct 2019 17:02:39 +0300 Message-ID: <838spjbhc0.fsf@gnu.org> References: <83bluhf7nz.fsf@gnu.org> <20191016111004.oialbyleokafpccz@Ergus> <87k194fvn7.fsf@mail.linkov.net> <871rvceeqp.fsf@mail.linkov.net> <83tv88cyic.fsf@gnu.org> <83pniwcvon.fsf@gnu.org> <87pniw30td.fsf@mail.linkov.net> <83k193dhdr.fsf@gnu.org> <83r23bbvdj.fsf@gnu.org> <83pnivbki7.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="118421"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37774@debbugs.gnu.org To: Andrey Orst Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 17 17:11:57 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iL7RV-000UbL-Iz for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Oct 2019 17:11:57 +0200 Original-Received: from localhost ([::1]:50560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iL7RT-0006uA-Go for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Oct 2019 11:11:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42493) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iL6Ns-0006lk-BZ for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 10:04:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iL6Nn-000687-46 for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 10:04:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39764) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iL6Nm-000681-Rx for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 10:04:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iL6Nm-0005nZ-Ks for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 10:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Oct 2019 14:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157132099422235 (code B ref 37774); Thu, 17 Oct 2019 14:04:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 17 Oct 2019 14:03:14 +0000 Original-Received: from localhost ([127.0.0.1]:48585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL6Mr-0005mQ-Aa for submit@debbugs.gnu.org; Thu, 17 Oct 2019 10:03:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33323) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL6Mo-0005lo-Np for 37774@debbugs.gnu.org; Thu, 17 Oct 2019 10:03:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iL6Mj-0005sY-IR; Thu, 17 Oct 2019 10:02:57 -0400 Original-Received: from [176.228.60.248] (port=3053 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iL6Mg-0005xV-E3; Thu, 17 Oct 2019 10:02:57 -0400 In-reply-to: (message from Andrey Orst on Thu, 17 Oct 2019 16:40:49 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169585 Archived-At: > From: Andrey Orst > Date: Thu, 17 Oct 2019 16:40:49 +0300 > Cc: 37774@debbugs.gnu.org > > Git diff is an inline diff. It doesn't need changes to be aligned side by side, > and doesn't need changes to be linked as in side by side diff tools like, > meld, and diff-viewers in Intellij Idea[1], VSCode[2], Sublime Merge[3], Smartgit[4], > > [1] https://www.oreilly.com/library/view/intellij-idea-essentials/9781784396930/graphics/6930OT_03_44.jpg > [2] https://www.meziantou.net/assets/result1.png?v=2c344912 > [3] https://edge.alluremedia.com.au/m/l/2018/09/smerge.png > [4] https://www.syntevo.com/assets/images/products/smartgit/opener-481720cb.png > > and even when we looking at inline diff, > most GUI tools use extended highlighters, > because it is easy to understand: > > sublime merge: https://i.ytimg.com/vi/ZrdkEBJV660/maxresdefault.jpg > Magit: https://magit.vc/screenshots/commit-top.png > > Consider looking at how magit supposed to look in official screenshots here, > and how it looks after the change. https://emacsair.me/2017/09/01/magit-walk-through/ So maybe a few more faces need to be extended, at least optionally. The issue that was brought up here was, AFAIU, that this feature breaks many features so badly that it needs to be reverted or at least turned off by default. I have yet to see some sound arguments for that.