unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Pablo Barbáchano" <pablo.barbachano@gmail.com>
Cc: 37814@debbugs.gnu.org
Subject: bug#37814: [PATCH] Add an option to preserve ANSI sequences
Date: Sat, 19 Oct 2019 09:12:12 +0300	[thread overview]
Message-ID: <838sph8ds3.fsf@gnu.org> (raw)
In-Reply-To: <20191018181813.21848-1-pablo.barbachano@gmail.com> (message from Pablo Barbáchano on Fri, 18 Oct 2019 20:18:13 +0200)

> From: Pablo Barbáchano <pablo.barbachano@gmail.com>
> Date: Fri, 18 Oct 2019 20:18:13 +0200
> Cc: Pablo Barbáchano <pablo.barbachano@gmail.com>
> 
> * lisp/ansi-color.el Add an option to preserve the ANSI sequences
> * test/lisp/ansi-color-tests.el: Add tests

Thank you for your contribution.

Could you please elaborate on the use case(s) that could benefit from
this change?

Also, using overlays would mean that copying the text elsewhere will
reveal the SGR sequences, is that intended?  If not, perhaps using
text properties would be better?

Did you consider using some non-trivial invisibility spec instead of
just t?  It's hard to say if this would make sense without knowing the
use cases you had in mind.

The commit log message is not formatted according to our conventions;
see CONTRIBUTE in the Emacs sources for the details.

Finally, these changes are too large for us to accept them without a
copyright assignment.  Would you like to start the legal paperwork to
that end?  If so, I will send you the form to fill.

Thanks again for your interest in Emacs.





  reply	other threads:[~2019-10-19  6:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18 18:18 bug#37814: [PATCH] Add an option to preserve ANSI sequences Pablo Barbáchano
2019-10-19  6:12 ` Eli Zaretskii [this message]
2019-11-01 20:25   ` Pablo Barbachano
2019-11-01 21:01     ` Eli Zaretskii
2020-08-09 18:42       ` Lars Ingebrigtsen
2020-08-09 19:38         ` Eli Zaretskii
2020-09-14 15:04           ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838sph8ds3.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=37814@debbugs.gnu.org \
    --cc=pablo.barbachano@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).