From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Thu, 14 Nov 2019 16:41:26 +0200 Message-ID: <838soi5xm1.fsf@gnu.org> References: <87o8xwrjba.fsf@bernoul.li> <834kzooo8e.fsf@gnu.org> <877e4d7yzf.fsf@bernoul.li> <83imnvg53q.fsf@gnu.org> <87zhh2ofc9.fsf@bernoul.li> <87k186nsku.fsf@bernoul.li> <83blte7kvc.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="45557"; mail-complaints-to="usenet@blaine.gmane.org" Cc: jonas@bernoul.li, 37774@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 14 15:43:37 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVGLP-000BhP-Iw for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Nov 2019 15:43:35 +0100 Original-Received: from localhost ([::1]:58320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVGLO-0005qh-Ap for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Nov 2019 09:43:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51568) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVGK0-0004cq-GF for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 09:42:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVGJw-0002r0-QP for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 09:42:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52347) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVGJt-0002qY-Qm for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 09:42:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iVGJt-0001AT-MZ for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 09:42:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Nov 2019 14:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.15737425124475 (code B ref 37774); Thu, 14 Nov 2019 14:42:01 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 14 Nov 2019 14:41:52 +0000 Original-Received: from localhost ([127.0.0.1]:32935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVGJj-0001A3-Bf for submit@debbugs.gnu.org; Thu, 14 Nov 2019 09:41:52 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42435) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVGJh-00019r-Sp for 37774@debbugs.gnu.org; Thu, 14 Nov 2019 09:41:50 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52124) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iVGJb-0002X5-Ac; Thu, 14 Nov 2019 09:41:43 -0500 Original-Received: from [176.228.60.248] (port=2583 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iVGJa-0005SI-GA; Thu, 14 Nov 2019 09:41:43 -0500 In-reply-to: (message from Dmitry Gutov on Thu, 14 Nov 2019 16:14:16 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171593 Archived-At: > Cc: 37774@debbugs.gnu.org > From: Dmitry Gutov > Date: Thu, 14 Nov 2019 16:14:16 +0200 > > > How is :extend different from any other face attribute? > > > > The documentation of custom-theme-set-faces says that FACE should be a > > face spec, like in defface. And the latter does override all the > > attributes, unless it uses :inherit. > > > > So I'm not unsure why you expected something else. > > *I* expected that going by your messages here and here: > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37774#104 > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37774#131 That was about custom-set-faces, not custom-theme-set-faces. The former is a function we write into the user files, so it's hard to expect anyone to insert :extend there. And it was only a question, to which I still don't have an answer (the issue of user face customizations somehow stopped being discussed). custom-theme-set-faces is different: it's code written by theme authors, so we could expect them to cater to :extend. > Then the backward compatibility problem is going to be bigger than I > thought. That's too bad. And my apologies to Jonas. We are still discussing, so I see no need for apologies. If the backward compatibility (or, rather, transparent DWIM-ish operation) is the overriding consideration, then you are actually saying that any face attribute we will introduce in the future will have to be treated the same? IOW, we will have to "inherit" it from the default face definition even if :inherit was not specified? If so, how does a theme refuse to "inherit" in this way?