From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28257: 26.0.50; [PATCH] expose eldoc functions in a hook Date: Fri, 14 Feb 2020 11:58:27 +0200 Message-ID: <838sl5pk1o.fsf@gnu.org> References: <87ziakwifi.fsf@holos> <87val88l0d.fsf@users.sourceforge.net> <20170828031104.GA15524@holos.localdomain> <87shgb89q1.fsf@users.sourceforge.net> <20170830015017.GA28668@holos.localdomain> <87wohasikq.fsf@gmail.com> <20190626140303.quhh4psgvd3aneyr@logos.localdomain> <20200126234731.GA12794@holos.localdomain> <838slnlo16.fsf@gnu.org> <83a75te6pr.fsf@gnu.org> <85pnekyehb.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="81934"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mvoteiza@udel.edu, larsi@gnus.org, 28257@debbugs.gnu.org To: Noam Postavsky , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 14 10:59:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j2Xkd-000LES-M3 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Feb 2020 10:59:11 +0100 Original-Received: from localhost ([::1]:36690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2Xkc-0000iq-MH for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Feb 2020 04:59:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57366) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2XkV-0000if-5j for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 04:59:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j2XkU-0001VR-7C for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 04:59:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54898) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j2XkU-0001VI-3F for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 04:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j2XkU-0000hr-1F for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 04:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Feb 2020 09:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28257 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28257-submit@debbugs.gnu.org id=B28257.15816743112670 (code B ref 28257); Fri, 14 Feb 2020 09:59:01 +0000 Original-Received: (at 28257) by debbugs.gnu.org; 14 Feb 2020 09:58:31 +0000 Original-Received: from localhost ([127.0.0.1]:60871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2Xjz-0000h0-9l for submit@debbugs.gnu.org; Fri, 14 Feb 2020 04:58:31 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42057) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2Xjx-0000gm-At for 28257@debbugs.gnu.org; Fri, 14 Feb 2020 04:58:29 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46228) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j2Xjr-0000HJ-O4; Fri, 14 Feb 2020 04:58:23 -0500 Original-Received: from [176.228.60.248] (port=2074 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j2Xjq-0008AU-BT; Fri, 14 Feb 2020 04:58:23 -0500 In-reply-to: <85pnekyehb.fsf@gmail.com> (message from Noam Postavsky on Tue, 11 Feb 2020 16:57:04 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176042 Archived-At: > From: Noam Postavsky > Cc: larsi@gnus.org, mvoteiza@udel.edu, 28257@debbugs.gnu.org > Date: Tue, 11 Feb 2020 16:57:04 -0500 > > > Can we please review Mark's patch some time soon? TIA. > > + (if (> emacs-major-version 25) > + (add-hook 'eldoc-documentation-functions > + #'cfengine3-documentation-function nil t) > > I think the 25 should be 26? Or 27 if this is going to master (in which > case the python.el hunk needs to be adjusted too). Otherwise, the patch > itself is fine in terms of coding details, as far as I can tell. Thanks. > I feel somewhat underqualified to decide whether or not the change in > the semantics of eldoc-documentation-function is a good idea. Thanks. I'm even less qualified here, but the same thoughts crossed my mind as well. Stefan, any comments or ideas? Who else might be relevant to discuss these changes?