From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22149: 24.4; gdb stack overflow in regexp matcher Date: Sat, 14 Mar 2020 12:14:24 +0200 Message-ID: <838sk3ckfz.fsf@gnu.org> References: <83y2s46o46.fsf@gnu.org> <30E3666D-A55F-45F1-9357-AA27E4C62D65@acm.org> <83tv2r74gg.fsf@gnu.org> <22A4D20C-E8EE-4C88-A3D9-6412D3C126B3@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="101731"; mail-complaints-to="usenet@ciao.gmane.io" Cc: schwab@suse.de, rhymer123@gmail.com, npostavs@gmail.com, 22149@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 14 11:15:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jD3p1-000QLO-DW for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Mar 2020 11:15:11 +0100 Original-Received: from localhost ([::1]:43452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jD3p0-0004rM-7J for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Mar 2020 06:15:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43502) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jD3ot-0004r1-CA for bug-gnu-emacs@gnu.org; Sat, 14 Mar 2020 06:15:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jD3os-0007BU-Ez for bug-gnu-emacs@gnu.org; Sat, 14 Mar 2020 06:15:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54661) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jD3os-0007Au-Bj for bug-gnu-emacs@gnu.org; Sat, 14 Mar 2020 06:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jD3os-0004DQ-8G for bug-gnu-emacs@gnu.org; Sat, 14 Mar 2020 06:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Mar 2020 10:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22149 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 22149-submit@debbugs.gnu.org id=B22149.158418087216156 (code B ref 22149); Sat, 14 Mar 2020 10:15:02 +0000 Original-Received: (at 22149) by debbugs.gnu.org; 14 Mar 2020 10:14:32 +0000 Original-Received: from localhost ([127.0.0.1]:60634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jD3oO-0004CW-0W for submit@debbugs.gnu.org; Sat, 14 Mar 2020 06:14:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jD3oM-0004CK-Tx for 22149@debbugs.gnu.org; Sat, 14 Mar 2020 06:14:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36635) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jD3oH-0006Fv-JS; Sat, 14 Mar 2020 06:14:25 -0400 Original-Received: from [176.228.60.248] (port=4284 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jD3oH-00083d-0X; Sat, 14 Mar 2020 06:14:25 -0400 In-Reply-To: <22A4D20C-E8EE-4C88-A3D9-6412D3C126B3@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Sat, 14 Mar 2020 10:04:38 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177335 Archived-At: > From: Mattias Engdegård > Date: Sat, 14 Mar 2020 10:04:38 +0100 > Cc: Noam Postavsky , 22149-done@debbugs.gnu.org, > Andreas Schwab , Cheng-An Yang > > 14 mars 2020 kl. 08.58 skrev Eli Zaretskii : > > > Moreover, we > > might decide, for different reasons, to bump up the stack size of the > > Emacs binary, which will indirectly fix this problem by making it less > > probable. > > I'm not sure how the C and regexp engine stacks relate to each other in practice -- main() attempts to grow the C stack to accommodate the maximal regexp stack, but SAFE_ALLOCA is set up to use the heap when necessary. Surely we could decouple them more or less entirely, since the extra cost for malloc is bound to be small when a lot of regexp stack is needed. I think regex-emacs.c already overrides some of the SAFE_ALLOCA machinery to that effect, does it not?