From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38181: Actual height of mode-line not taken into account Date: Tue, 05 May 2020 17:58:05 +0300 Message-ID: <838si6mnsy.fsf@gnu.org> References: <87eeyd3ul0.fsf@bernoul.li> <83d0dt2qt6.fsf@gnu.org> <83r2290w24.fsf@gnu.org> <83pnhs6wwp.fsf@gnu.org> <83k1806qca.fsf@gnu.org> <8336en7giv.fsf@gnu.org> <81264049-4f88-fae7-6448-e0ac5d977268@gmx.at> <83a78u5s8y.fsf@gnu.org> <01cee2f7-aeb5-4eb1-b2d5-e056c91eab8b@gmx.at> <83wo5rolsc.fsf@gnu.org> <4682372c-e25a-dc62-842f-c3971f79bb16@gmx.at> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="97188"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jonas@bernoul.li, 38181@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 05 16:59:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jVz2P-000PBA-Re for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 May 2020 16:59:13 +0200 Original-Received: from localhost ([::1]:33816 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVz2O-0000PS-Ul for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 May 2020 10:59:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVz2E-0000PF-Gv for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 10:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53722) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVz2E-0000uJ-7u for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 10:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jVz2E-0000tw-7u for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 10:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 May 2020 14:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38181 X-GNU-PR-Package: emacs Original-Received: via spool by 38181-submit@debbugs.gnu.org id=B38181.15886907183434 (code B ref 38181); Tue, 05 May 2020 14:59:02 +0000 Original-Received: (at 38181) by debbugs.gnu.org; 5 May 2020 14:58:38 +0000 Original-Received: from localhost ([127.0.0.1]:37035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVz1p-0000tJ-Kj for submit@debbugs.gnu.org; Tue, 05 May 2020 10:58:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVz1n-0000t3-Tc for 38181@debbugs.gnu.org; Tue, 05 May 2020 10:58:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55767) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVz1h-0007oo-Tu; Tue, 05 May 2020 10:58:29 -0400 Original-Received: from [176.228.60.248] (port=2704 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jVz1e-0007qA-Hi; Tue, 05 May 2020 10:58:27 -0400 In-Reply-To: (message from martin rudalics on Tue, 5 May 2020 10:32:31 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179735 Archived-At: > From: martin rudalics > Cc: jonas@bernoul.li, 38181@debbugs.gnu.org > Date: Tue, 5 May 2020 10:32:31 +0200 > > Below find two backtraces with emacs -Q where PRODUCE_GLYPHS here sets > inhibit_free_realized_faces outside the scope of redisplay_internal > (that is, while redisplaying_p is nil) such that these will not get > caught by the unbind form in redisplay_internal. Thanks. All of these enter redisplay via echo_area_display. That calls redisplay_internal, but only after it displays the mini-window. However, I had my doubts regarding the accuracy of my mental model. Namely, the part where I said that inhibit_free_realized_faces should never be non-zero outside of redisplay. So I looked at the code and its history, and it turns out I was wrong: the line that sets the flag in PRODUCE_GLYPHS was there since Emacs 21, and I see the flag set to non-zero all the way back to Emacs 22.1 (and probably earlier). So it sounds like we always were running like that. Therefore, I must turn the table and ask you to please describe in more detail, preferably with Lisp snippets to try, how the fact that this flag is non-zero gets in the way of something we need to do with faces, both in this bug and the other one you mentioned. I'd like to understand better how this flag interferes in these use cases. Thanks (and sorry for spreading misinformation: I was somehow confident that it was myself who added the setting of inhibit_free_realized_faces in PRODUCE_GLYPHS, but the truth is that it was Gerd, long ago).