From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#42184: 27.0.91; org-fontify-whole-heading-line does not work in emacs 27 Date: Sun, 05 Jul 2020 17:58:12 +0300 Message-ID: <838sfyt3ej.fsf@gnu.org> References: <5effe96e.1c69fb81.3a20a.f99f@mx.google.com> <87mu4f2ofd.fsf@gmail.com> <83wo3jtd0t.fsf@gnu.org> <87h7un2mq9.fsf@gmail.com> <87y2nzvz13.fsf@gmail.com> <83o8ouu200.fsf@gnu.org> <87blkufif5.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20735"; mail-complaints-to="usenet@ciao.gmane.io" Cc: egh@e6h.org, 42184@debbugs.gnu.org, mail@nicolasgoaziou.fr, bzg@gnu.org To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 05 16:59:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1js66r-0005JS-3Z for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Jul 2020 16:59:13 +0200 Original-Received: from localhost ([::1]:41112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1js66q-0007Np-35 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Jul 2020 10:59:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1js66f-0007NR-Ur for bug-gnu-emacs@gnu.org; Sun, 05 Jul 2020 10:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49565) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1js66f-0002bL-Lz for bug-gnu-emacs@gnu.org; Sun, 05 Jul 2020 10:59:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1js66f-00055F-LN for bug-gnu-emacs@gnu.org; Sun, 05 Jul 2020 10:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jul 2020 14:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42184 X-GNU-PR-Package: emacs Original-Received: via spool by 42184-submit@debbugs.gnu.org id=B42184.159396109719489 (code B ref 42184); Sun, 05 Jul 2020 14:59:01 +0000 Original-Received: (at 42184) by debbugs.gnu.org; 5 Jul 2020 14:58:17 +0000 Original-Received: from localhost ([127.0.0.1]:32878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1js65x-00054G-Dk for submit@debbugs.gnu.org; Sun, 05 Jul 2020 10:58:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1js65v-000542-Rp for 42184@debbugs.gnu.org; Sun, 05 Jul 2020 10:58:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33555) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1js65o-0002WG-Ur; Sun, 05 Jul 2020 10:58:08 -0400 Original-Received: from [176.228.60.248] (port=3193 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1js65n-0000ex-9F; Sun, 05 Jul 2020 10:58:07 -0400 In-Reply-To: <87blkufif5.fsf@gmail.com> (message from =?UTF-8?Q?K=C3=A9vin?= Le Gouguec on Sun, 05 Jul 2020 10:57:34 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182741 Archived-At: > From: Kévin Le Gouguec > Cc: egh@e6h.org, 42184@debbugs.gnu.org, mail@nicolasgoaziou.fr, bzg@gnu.org > Date: Sun, 05 Jul 2020 10:57:34 +0200 > > > I don't understand why you extend all those faces: the original report > > was about a much smaller set. It is not the intent that every face > > that happens to span the entire line be extended: that's why we made > > ':extend' by default be off for a face. > > > > What am I missing? > > The original report was about the org-level-1 and org-level-2 faces, as > well as org-block-begin-line and the org-block-end-line. Yes. So I'd expect to see the respective faces have the :extend attribute under each one of the 2 options cited in the original report. > The only faces I added were org-level-[3-8], because I don't see why > different heading levels should not work with > org-fontify-whole-heading-line. The original code only affects certain heading levels, it doesn't affect all of them. So I see no need for any "consistency" here. More generally, the :extend attribute is by default off because we want most of the faces not to be extended. Let's only extend the minimum, not anything that could be extended in principle. Which is another aspect of your proposed patch I'd like to change: it seems to cause these faces be extended unconditionally, not just under these optional variables. Or did I miss something? > AFAICT, this is the simplest way to fix org-fontify-whole-heading-line > and org-fontify-whole-block-delimiter-line for Emacs ≥27. These user > options work under the assumption that simply fontifying the final > newline is enough to extend attributes past EOL. Nevertheless, I would like to see the :extend attribute applied only under the above options; there's the set-face-extend function for doing that. > The long term fix might be for Org to (1) deprecate these user options > and let themes and/or users apply :extend t themselves, or (2) slap > :extend t onto the faces when setting up the major mode fontification > depending on these user options (Org already does similar on-the-fly > face tweaks; see e.g. org-hide). Or something else. I don't see why these options should be deprecated, and even less why the faces should have the :extend attribute. It would go against the intent behind introducing that attribute in the first place. Thanks.