From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#9366: Display geometry change hook Date: Sat, 19 Sep 2020 18:42:23 +0300 Message-ID: <838sd53h9c.fsf@gnu.org> References: <4E55DACA.6080401@harpegolden.net> <87363dpyz3.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19322"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 9366@debbugs.gnu.org To: Lars Ingebrigtsen , martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 19 17:43:51 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJf1j-0004w4-5R for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Sep 2020 17:43:51 +0200 Original-Received: from localhost ([::1]:52452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJf1i-0008Kd-3N for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Sep 2020 11:43:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47584) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJf0w-0007Yd-5C for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 11:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36286) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJf0v-00058l-PV for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 11:43:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJf0v-0003ED-MV for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 11:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Sep 2020 15:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9366 X-GNU-PR-Package: emacs Original-Received: via spool by 9366-submit@debbugs.gnu.org id=B9366.160053015712369 (code B ref 9366); Sat, 19 Sep 2020 15:43:01 +0000 Original-Received: (at 9366) by debbugs.gnu.org; 19 Sep 2020 15:42:37 +0000 Original-Received: from localhost ([127.0.0.1]:47832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJf0W-0003DR-OV for submit@debbugs.gnu.org; Sat, 19 Sep 2020 11:42:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJf0U-0003DC-GC for 9366@debbugs.gnu.org; Sat, 19 Sep 2020 11:42:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46578) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJf0O-00056s-05; Sat, 19 Sep 2020 11:42:28 -0400 Original-Received: from [176.228.60.248] (port=2818 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kJf0M-0003WG-JE; Sat, 19 Sep 2020 11:42:27 -0400 In-Reply-To: <87363dpyz3.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 19 Sep 2020 17:28:48 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188399 Archived-At: > From: Lars Ingebrigtsen > Date: Sat, 19 Sep 2020 17:28:48 +0200 > Cc: 9366@debbugs.gnu.org > > > +#ifdef HAVE_XRANDR > > + /* xrandr extension may or may not be present on a display => > > + can't check for it as a constant C "case" arg, hence "if" here */ > > + if (dpyinfo->xrandr_present && > > + (event.type == (dpyinfo->xrandr_event_base + RRScreenChangeNotify))) > > + { > > + /* FIXME: is XRRUpdateConfiguration actually called by the toolkit/gtk+? > > But looking through the code, it doesn't seem like Emacs has grown this > capability over the years? But I may be looking in the wrong places. > > In any case, it sounds useful? I haven't tried applying the patch, > though, so I don't know how much work that would be to bring it up to > date. > > Anybody got any opinions here? Do we really have to do this on such a low level? Why cannot we call such a hook from change_frame_size, which would allow us to do that in platform-independent manner? Martin, am I missing something here?