unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: sam.brightman@gmail.com
Cc: 43886@debbugs.gnu.org
Subject: bug#43886: 28.0.50; daemon segfaults when loading theme as second emacsclient connects
Date: Sat, 10 Oct 2020 11:17:10 +0300	[thread overview]
Message-ID: <838sce5wc9.fsf@gnu.org> (raw)
In-Reply-To: <83d01q5ywn.fsf@gnu.org> (message from Eli Zaretskii on Sat, 10 Oct 2020 10:21:44 +0300)

> Date: Sat, 10 Oct 2020 10:21:44 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 43886@debbugs.gnu.org
> 
> > However - even removing that hook - it is now impossible to
> > load a theme when a client is suspended (which is basically always for
> > me - I'll have half a dozen or more clients open at any time, one of
> > them will be suspended).
> 
> It is indeed impossible/unsafe to load a theme when some frame is
> suspended, because suspending a frame makes it unable to handle the
> change of the faces.  I don't see any way around that, because
> skipping such a frame when a theme is enabled would mean that frame's
> faces are not recalculated to obey the theme, which is a subtler and
> nastier bug, IMO.
> 
> You will have to unsuspend the frames when you load a theme.

Upon further thought, I found a simpler, nicer solution for this
conundrum, and pushed it to the emacs-27 branch.





  reply	other threads:[~2020-10-10  8:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-09 15:58 bug#43886: 28.0.50; daemon segfaults when loading theme as second emacsclient connects Sam Brightman
2020-10-09 19:32 ` Eli Zaretskii
2020-10-10  7:09   ` Sam Brightman
2020-10-10  7:21     ` Eli Zaretskii
2020-10-10  8:17       ` Eli Zaretskii [this message]
2020-10-10 13:27         ` Sam Brightman
2020-10-10 13:35           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838sce5wc9.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=43886@debbugs.gnu.org \
    --cc=sam.brightman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).