unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: larsi@gnus.org, 43117@debbugs.gnu.org, rpluim@gmail.com,
	leungbk@mailfence.com, dgutov@yandex.ru
Subject: bug#43117: [PATCH] Add .git-blame-ignore-revs file
Date: Mon, 19 Oct 2020 19:40:08 +0300	[thread overview]
Message-ID: <838sc2p3tj.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmn8p+r7z0c=tJKabJV_68WVKEcvJEMVqKbb2TaB+jSfQA@mail.gmail.com> (message from Stefan Kangas on Mon, 19 Oct 2020 16:06:45 +0000)

> From: Stefan Kangas <stefan@marxist.se>
> Date: Mon, 19 Oct 2020 16:06:45 +0000
> Cc: leungbk@mailfence.com, larsi@gnus.org, rpluim@gmail.com, 
> 	43117@debbugs.gnu.org, dgutov@yandex.ru
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Why would someone want to skip commits in "git blame"?  We need to
> > have agreed-upon criteria or policy for that, otherwise each one of
> > use will step on the others' toes.  "git blame" is an important
> > forensics command, so hiding commits from it might surprise someone,
> > if it's unexpected.
> 
> For example, if a commit fixed a typo in a doc string, I'd much rather
> see the commit that added that text than the one that fixed the typo.

But that's your personal preference, isn't it?  Do we know for sure no
one will ever want to see changes that fixed typos?  For example, what
about some "typo" that is controversial (like the "parseable" thing we
discussed lately), and we want to know who and why "fixed" it?

In short, the more I think about this feature, the less it makes sense
to me to use it in our project.  It's probably fine for a
single-developer projects, where the preferences are never in
conflict.  But ours is a very different project.

> >> Wouldn't having non-existent commit ids in there mostly be an aesthetic
> >> problem?
> >
> > I don't know.  Will it?  I have no experience with this feature.
> 
> AFAIU, git will just skip over non-existent commits in this case.

It requires a setting in .git/config, doesn't it?  Would older
versions of Git warn about the setting they don't know about?  Or do
we expect users to turn this on in their ~/.gitconfig instead?





  reply	other threads:[~2020-10-19 16:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-30 17:46 bug#43117: [PATCH] Add .git-blame-ignore-revs file Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-31 10:16 ` Robert Pluim
2020-08-31 20:11   ` Dmitry Gutov
2020-08-31 20:34     ` Robert Pluim
2020-08-31 20:45       ` Dmitry Gutov
2020-08-31 20:57         ` Robert Pluim
2020-08-31 21:03           ` Dmitry Gutov
2020-09-13  0:42             ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-09-13 14:07               ` Eli Zaretskii
2020-09-13 17:06                 ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-09-13 17:34                   ` Eli Zaretskii
2020-09-13 17:57                     ` Lars Ingebrigtsen
2020-09-13 18:49                       ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-18 17:03                         ` Stefan Kangas
2020-10-18 17:18                           ` Eli Zaretskii
2020-10-18 17:54                             ` Stefan Kangas
2020-10-18 17:59                               ` Eli Zaretskii
2020-10-18 18:25                                 ` Stefan Kangas
2020-10-18 18:41                                   ` Eli Zaretskii
2020-10-19 16:06                                     ` Stefan Kangas
2020-10-19 16:40                                       ` Eli Zaretskii [this message]
2020-10-20 10:38                                         ` Lars Ingebrigtsen
2020-10-20 12:05                                           ` Stefan Kangas
2021-03-12  1:07                                             ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838sc2p3tj.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=43117@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=larsi@gnus.org \
    --cc=leungbk@mailfence.com \
    --cc=rpluim@gmail.com \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).