From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#45198: 28.0.50; Sandbox mode Date: Tue, 29 Dec 2020 17:43:57 +0200 Message-ID: <838s9gk476.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2686"; mail-complaints-to="usenet@ciao.gmane.io" Cc: bzg@gnu.org, 45198@debbugs.gnu.org, monnier@iro.umontreal.ca, joaotavora@gmail.com To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 29 16:45:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kuHBN-0000Zc-Cu for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Dec 2020 16:45:09 +0100 Original-Received: from localhost ([::1]:34034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuHBM-0005Wk-FZ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Dec 2020 10:45:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuHBF-0005WH-Sy for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 10:45:01 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56654) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kuHBF-0006YR-LY for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 10:45:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kuHBF-0007e7-I1 for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 10:45:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Dec 2020 15:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45198 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45198-submit@debbugs.gnu.org id=B45198.160925665129312 (code B ref 45198); Tue, 29 Dec 2020 15:45:01 +0000 Original-Received: (at 45198) by debbugs.gnu.org; 29 Dec 2020 15:44:11 +0000 Original-Received: from localhost ([127.0.0.1]:39967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuHAR-0007ch-5q for submit@debbugs.gnu.org; Tue, 29 Dec 2020 10:44:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuHAP-0007cT-Tf for 45198@debbugs.gnu.org; Tue, 29 Dec 2020 10:44:10 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:32976) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuHAK-0006DO-7C; Tue, 29 Dec 2020 10:44:04 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1934 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kuHAJ-0002Hc-39; Tue, 29 Dec 2020 10:44:03 -0500 In-Reply-To: (message from Philipp Stephani on Tue, 29 Dec 2020 14:50:56 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196942 Archived-At: > From: Philipp Stephani > Date: Tue, 29 Dec 2020 14:50:56 +0100 > Cc: Bastien , 45198@debbugs.gnu.org, > João Távora > > I've pushed a modified version of these two patches onto the > scratch/seccomp branch. Thank you for working on this. > It would be great if someone could test whether the Windows build > still works after that, thanks! I only skimmed the changes, but I'm already quite sure they will break the Windows build. This feature is not relevant to the MS-Windows build of Emacs, at least currently (I don't think Windows implements equivalent features in a way that is even remotely similar to GNU/Linux). So to make sure the Windows port doesn't break, we must take every measure to avoid compiling any of the related code on MS-Windows. In particular: . Gnulib modules pulled to support seccomp should be disabled in the MS-Windows build, by suitable changes to nt/mingw-cfg.site and/or nt/gnulib-cfg.mk; and . header files used to support seccomp code should be #ifdef'ed by HAVE_LINUX_SECCOMP_H or similar, and likewise with any code needed for seccomp and unnecessary otherwise. Btw, I wonder why you needed to import the read-file module from Gnulib -- does it provide any features that we couldn't implement on our own? I'm asking because that module caused you to pull in quite a few dependency modules from Gnulib, and I'm asking myself whether that is really justified.