From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#46834: 28.0.50; byte-compiling the standard counter closure fails Date: Tue, 02 Mar 2021 15:16:52 +0200 Message-ID: <838s757l17.fsf@gnu.org> References: <87eegyyr8v.fsf@gnus.org> <874khuypo9.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28100"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46834@debbugs.gnu.org, monnier@iro.umontreal.ca, pipcet@gmail.com To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 02 14:18:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lH4ug-0007BZ-25 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Mar 2021 14:18:10 +0100 Original-Received: from localhost ([::1]:51036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lH4uf-0006CO-4Y for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Mar 2021 08:18:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45058) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lH4uY-0006Al-LT for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 08:18:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40512) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lH4uY-0000H5-EK for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 08:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lH4uY-0008TT-AP for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 08:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Mar 2021 13:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46834 X-GNU-PR-Package: emacs Original-Received: via spool by 46834-submit@debbugs.gnu.org id=B46834.161469102232483 (code B ref 46834); Tue, 02 Mar 2021 13:18:02 +0000 Original-Received: (at 46834) by debbugs.gnu.org; 2 Mar 2021 13:17:02 +0000 Original-Received: from localhost ([127.0.0.1]:52058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lH4ta-0008Rr-HI for submit@debbugs.gnu.org; Tue, 02 Mar 2021 08:17:02 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lH4tY-0008RH-Pu for 46834@debbugs.gnu.org; Tue, 02 Mar 2021 08:17:01 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39985) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lH4tT-000092-C8; Tue, 02 Mar 2021 08:16:55 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1257 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lH4tS-0001Uc-9d; Tue, 02 Mar 2021 08:16:54 -0500 In-Reply-To: <874khuypo9.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 02 Mar 2021 08:34:30 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201211 Archived-At: > From: Lars Ingebrigtsen > Date: Tue, 02 Mar 2021 08:34:30 +0100 > Cc: 46834@debbugs.gnu.org, Stefan Monnier > > Pip Cet writes: > > > On Tue, Mar 2, 2021 at 7:00 AM Lars Ingebrigtsen wrote: > >> Pip, are you pushing this fix yourself, or do you want me to do it? > > > > It's been a while since I pushed, did I get that right? > > Yup; looks perfect. Almost perfect: * lisp/emacs-lisp/bytecomp.el (byte-compile--reify-function): Don't move let bindings into the lambda. Don't reverse list of bindings. (byte-compile): Evaluate the return value if it was previously reified. The "(byte-compile):" part should have begun on a new line. (It is always better to use "C-x 4 a" or similar commands to write log entries, as then Emacs will format the messages for you.)