From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#45379: 28.0.50; Degraded Performance of describe-buffer-bindings Date: Tue, 30 Mar 2021 10:01:19 +0300 Message-ID: <838s65ktvk.fsf@gnu.org> References: <874khnzqls.fsf@gnu.org> <83r1krtrpt.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26008"; mail-complaints-to="usenet@ciao.gmane.io" Cc: styang@fastmail.com, 45379@debbugs.gnu.org, stefan@marxist.se, juri@linkov.net, handa@gnu.org, monnier@iro.umontreal.ca, stephen.berman@gmx.net To: Kenichi Handa Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 30 09:02:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lR8OA-0006dl-56 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Mar 2021 09:02:10 +0200 Original-Received: from localhost ([::1]:52094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lR8O9-0000Wt-3S for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Mar 2021 03:02:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lR8O2-0000Wd-PT for bug-gnu-emacs@gnu.org; Tue, 30 Mar 2021 03:02:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38685) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lR8O2-0005OH-Ho for bug-gnu-emacs@gnu.org; Tue, 30 Mar 2021 03:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lR8O2-0001Yu-G3 for bug-gnu-emacs@gnu.org; Tue, 30 Mar 2021 03:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Mar 2021 07:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45379 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch confirmed Original-Received: via spool by 45379-submit@debbugs.gnu.org id=B45379.16170876844011 (code B ref 45379); Tue, 30 Mar 2021 07:02:02 +0000 Original-Received: (at 45379) by debbugs.gnu.org; 30 Mar 2021 07:01:24 +0000 Original-Received: from localhost ([127.0.0.1]:50231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lR8NL-0000wq-89 for submit@debbugs.gnu.org; Tue, 30 Mar 2021 03:01:24 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lR8NI-0000qf-Ph for 45379@debbugs.gnu.org; Tue, 30 Mar 2021 03:01:17 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60840) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lR8NB-0004jw-VS; Tue, 30 Mar 2021 03:01:09 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1160 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lR8NA-0008Ob-24; Tue, 30 Mar 2021 03:01:08 -0400 In-Reply-To: <83r1krtrpt.fsf@gnu.org> (message from Eli Zaretskii on Sun, 07 Mar 2021 08:15:10 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203280 Archived-At: Ping! Kenichi, could you please help us with this issue? > Date: Sun, 07 Mar 2021 08:15:10 +0200 > From: Eli Zaretskii > Cc: stephen.berman@gmx.net, 45379@debbugs.gnu.org, stefan@marxist.se, > juri@linkov.net, handa@gnu.org, monnier@iro.umontreal.ca, styang@fastmail.com > > > From: handa > > Cc: stefan@marxist.se, styang@fastmail.com, juri@linkov.net, rudalics@gmx.at, > > 45379@debbugs.gnu.org, monnier@iro.umontreal.ca, > > stephen.berman@gmx.net, handa@gnu.org > > Date: Sun, 07 Mar 2021 10:42:39 +0900 > > > > In article <83v9a4wve3.fsf@gnu.org>, Eli Zaretskii writes: > > > > > > From: Stefan Kangas > > > > Date: Fri, 5 Mar 2021 20:44:33 -0800 > > > > Cc: Juri Linkov , martin rudalics , Eli Zaretskii , > > > > 45379@debbugs.gnu.org, Stefan Monnier , > > > > Stephen Berman > > > > > > > > It turns out that we were doing unnecessary looping due to the above > > > > mentioned commit. > > > > Could you show me what is "the above mentioned commit"? > > This one, I guess: > > > commit a6490343366f2b2331a91dcb693effb3a9dd78f5 > > Author: Stefan Kangas > > AuthorDate: Fri Nov 13 15:28:29 2020 +0100 > > Commit: Stefan Kangas > > CommitDate: Sun Nov 22 02:45:03 2020 +0100 > > > > Don't show key ranges if shadowed by different commands > > > > * src/keymap.c (describe_vector): Make sure found consecutive keys > > are either not shadowed or, if they are, that they are shadowed by > > the same command. (Bug#9293) > > * test/src/keymap-tests.el > > (help--describe-vector/bug-9293-one-shadowed-in-range): New test. > > > > > While working on this, I also found that we can get > > > > rid of an unnecessary call to char_table_ref_and_range, which should > > > > make this function run even faster. > > > > Is the patch for the above improvement the one included in the file > > 0001-Fix-describe-buffer-bindings-performance-regression.patch? > > Yes, it is. > > > > > I'm also copying in Kenichi Handa, who was the last to touch this code. > > > > Handa-san, please let us know if you have any comments on this patch. > > > > Thanks in advance. > > > > > AFAICT, you didn't CC Kenichi; I have now added him to the discussion. > > > > It was more than 10 years ago that I last read keymap.c, and since then, > > the code has been changed a lot. It will take some time to understand > > the latest code. > > Thanks in advance.