From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] Date: Wed, 28 Apr 2021 14:58:58 +0300 Message-ID: <838s52hb7h.fsf@gnu.org> References: <20210427190243.n5yg3gywd5wma3jl@E15-2016.optimum.net> <83lf93h6x1.fsf@gnu.org> <20210427193253.ourhlr3nxdem3e6t@E15-2016.optimum.net> <83k0ongnc7.fsf@gnu.org> <20210428030025.75hiu5zgrll2qzeq@E15-2016.optimum.net> <87fszbnd70.fsf@gmail.com> <20210428095054.wkpyxl2axhdx26dq@E15-2016.optimum.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36632"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48072@debbugs.gnu.org, kevin.legouguec@gmail.com To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 28 14:00:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbirY-0009NT-S1 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Apr 2021 14:00:16 +0200 Original-Received: from localhost ([::1]:34440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbirX-0002zw-CZ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Apr 2021 08:00:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbirK-0002zf-VR for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 08:00:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40384) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lbirK-0005um-OK for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 08:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lbirK-0005hZ-M8 for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 08:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Apr 2021 12:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48072-submit@debbugs.gnu.org id=B48072.161961116221828 (code B ref 48072); Wed, 28 Apr 2021 12:00:02 +0000 Original-Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 11:59:22 +0000 Original-Received: from localhost ([127.0.0.1]:51925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbiqg-0005fz-6U for submit@debbugs.gnu.org; Wed, 28 Apr 2021 07:59:22 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbiqe-0005fm-2w for 48072@debbugs.gnu.org; Wed, 28 Apr 2021 07:59:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41732) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbiqY-0005Oc-LQ; Wed, 28 Apr 2021 07:59:14 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1418 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lbiqS-0004J0-Th; Wed, 28 Apr 2021 07:59:11 -0400 In-Reply-To: <20210428095054.wkpyxl2axhdx26dq@E15-2016.optimum.net> (message from Boruch Baum on Wed, 28 Apr 2021 05:50:54 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205098 Archived-At: > Date: Wed, 28 Apr 2021 05:50:54 -0400 > From: Boruch Baum > Cc: Eli Zaretskii , 48072@debbugs.gnu.org > > I could restrict the check to the preparation of list of completion > candidates for the defaults put into the mini-buffer history (already > done in diredc, as an advice around function dired-guess-default), and > give dired users feedback when a command returns an error condition (on > this week's plan anyway). I'm not sure I understand what you are suggesting. Do you mean set up the completion candidates so that they would only include executable files found on the system, but allow users also to type commands that are not among the completion candidates? I think this could be confusing, and I don't think we have a precedent for such a behavior elsewhere.