From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command Date: Mon, 03 May 2021 15:09:01 +0300 Message-ID: <838s4w6mua.fsf@gnu.org> References: <24706.50397.801563.461736@capuchin.co.uk> <7ee648e84004b7745946@heytings.org> <24709.3891.605753.919647@capuchin.co.uk> <677a04021b23aa2d7c9f@heytings.org> <24709.24669.871737.299611@capuchin.co.uk> <677a04021b6d6347bbd2@heytings.org> <4edb1435266ad41487a5@heytings.org> <8fdeca1f-7d34-c95a-0f2d-5550dea34512@gmx.at> <242e45b6-6dee-c85a-2ac8-67b2adeb93b5@gmx.at> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1641"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gregory@heytings.org, 47969@debbugs.gnu.org, robert@capuchin.co.uk To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 03 14:10:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldXOs-0000KS-2d for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 May 2021 14:10:10 +0200 Original-Received: from localhost ([::1]:60080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldXOr-0000WL-4W for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 May 2021 08:10:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50622) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldXOk-0000WE-HS for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 08:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34848) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldXOk-0004Y2-9f for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 08:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ldXOk-0003iZ-44 for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 08:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 May 2021 12:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47969 X-GNU-PR-Package: emacs Original-Received: via spool by 47969-submit@debbugs.gnu.org id=B47969.162004376914276 (code B ref 47969); Mon, 03 May 2021 12:10:02 +0000 Original-Received: (at 47969) by debbugs.gnu.org; 3 May 2021 12:09:29 +0000 Original-Received: from localhost ([127.0.0.1]:46394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldXOC-0003iC-LM for submit@debbugs.gnu.org; Mon, 03 May 2021 08:09:28 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldXOA-0003i6-P7 for 47969@debbugs.gnu.org; Mon, 03 May 2021 08:09:27 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51487) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldXO4-00049B-Bz; Mon, 03 May 2021 08:09:20 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1333 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ldXO3-0005is-Mw; Mon, 03 May 2021 08:09:20 -0400 In-Reply-To: <242e45b6-6dee-c85a-2ac8-67b2adeb93b5@gmx.at> (message from martin rudalics on Mon, 3 May 2021 14:02:13 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205505 Archived-At: > From: martin rudalics > Date: Mon, 3 May 2021 14:02:13 +0200 > Cc: Robert Marshall , 47969@debbugs.gnu.org > > > Okay, I bisected this, and the culprit is commit 3fdd3bb56c. Interestingly, that commit removed the following from handle-select-window: > > > > ;; Don't switch if we're currently in the minibuffer. > > ;; This tries to work around problems where the > > ;; minibuffer gets unselected unexpectedly, and where > > ;; you then have to move your mouse all the way down to > > ;; the minibuffer to select it. > > (window-minibuffer-p) > > > > which happens to be what my patch adds again. > > I can't give a reasonable explanation why I removed that back then, so > please re-add it as soon as your paperwork is done. I'd actually trust your-then judgment, and instead explore the possibility of solving this as I proposed up-thread. Undoing past fixes when we don't understand the effects is bad mantra, it runs the risk of fixing one problem by reintroducing another. > And many thanks for the bisection, great work as usual. Seconded.