From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: gregory@heytings.org, 47969@debbugs.gnu.org, robert@capuchin.co.uk
Subject: bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command
Date: Mon, 03 May 2021 15:09:01 +0300 [thread overview]
Message-ID: <838s4w6mua.fsf@gnu.org> (raw)
In-Reply-To: <242e45b6-6dee-c85a-2ac8-67b2adeb93b5@gmx.at> (message from martin rudalics on Mon, 3 May 2021 14:02:13 +0200)
> From: martin rudalics <rudalics@gmx.at>
> Date: Mon, 3 May 2021 14:02:13 +0200
> Cc: Robert Marshall <robert@capuchin.co.uk>, 47969@debbugs.gnu.org
>
> > Okay, I bisected this, and the culprit is commit 3fdd3bb56c. Interestingly, that commit removed the following from handle-select-window:
> >
> > ;; Don't switch if we're currently in the minibuffer.
> > ;; This tries to work around problems where the
> > ;; minibuffer gets unselected unexpectedly, and where
> > ;; you then have to move your mouse all the way down to
> > ;; the minibuffer to select it.
> > (window-minibuffer-p)
> >
> > which happens to be what my patch adds again.
>
> I can't give a reasonable explanation why I removed that back then, so
> please re-add it as soon as your paperwork is done.
I'd actually trust your-then judgment, and instead explore the
possibility of solving this as I proposed up-thread. Undoing past
fixes when we don't understand the effects is bad mantra, it runs the
risk of fixing one problem by reintroducing another.
> And many thanks for the bisection, great work as usual.
Seconded.
next prev parent reply other threads:[~2021-05-03 12:09 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 13:00 bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command Robert Marshall
2021-04-24 17:29 ` Gregory Heytings
2021-04-25 6:41 ` Robert Marshall
2021-04-25 9:58 ` Gregory Heytings
2021-04-25 12:28 ` Robert Marshall
2021-04-25 12:29 ` Gregory Heytings
2021-05-01 20:20 ` Gregory Heytings
2021-05-02 6:40 ` Eli Zaretskii
2021-05-03 9:07 ` Lars Ingebrigtsen
2021-05-03 11:54 ` Eli Zaretskii
2021-05-03 12:15 ` Gregory Heytings
2021-05-03 12:18 ` Eli Zaretskii
2021-05-02 7:39 ` martin rudalics
2021-05-02 8:01 ` Robert Marshall
2021-05-03 8:42 ` Gregory Heytings
2021-05-03 9:38 ` martin rudalics
2021-05-03 9:41 ` Gregory Heytings
2021-05-03 11:19 ` Gregory Heytings
2021-05-03 12:02 ` martin rudalics
2021-05-03 12:09 ` Eli Zaretskii [this message]
2021-05-03 12:20 ` Gregory Heytings
2021-05-03 17:31 ` martin rudalics
2021-05-03 17:46 ` Eli Zaretskii
2021-05-04 7:41 ` Gregory Heytings
2021-05-04 11:59 ` Eli Zaretskii
2021-05-04 13:04 ` Gregory Heytings
2021-05-04 13:17 ` Eli Zaretskii
2021-05-04 13:26 ` Gregory Heytings
2021-05-04 14:02 ` Eli Zaretskii
2021-05-04 14:43 ` Gregory Heytings
2021-05-04 15:19 ` Eli Zaretskii
2021-05-05 7:25 ` martin rudalics
2021-05-05 9:02 ` Gregory Heytings
2021-05-05 9:25 ` martin rudalics
2021-05-05 9:40 ` Gregory Heytings
2021-05-05 11:24 ` martin rudalics
2021-05-05 12:06 ` Eli Zaretskii
2021-05-06 7:44 ` martin rudalics
2021-05-06 8:06 ` Eli Zaretskii
2021-05-06 13:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-06 13:50 ` Gregory Heytings
2021-05-06 14:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-08 12:38 ` Eli Zaretskii
2021-05-08 13:36 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-25 8:52 ` Gregory Heytings
2021-05-25 19:40 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838s4w6mua.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=47969@debbugs.gnu.org \
--cc=gregory@heytings.org \
--cc=robert@capuchin.co.uk \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).