From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#49722: 27.2; Emacs won't build with old versions of fontconfig Date: Sun, 25 Jul 2021 09:43:01 +0300 Message-ID: <838s1uyjuy.fsf@gnu.org> References: <87k0lg115s.fsf@163.com> <83zguby8fd.fsf@gnu.org> <87o8arz00o.fsf@163.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6190"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49722@debbugs.gnu.org To: Andrei Kuznetsov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 25 08:44:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7Xrx-0001Rx-7u for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Jul 2021 08:44:13 +0200 Original-Received: from localhost ([::1]:58788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7Xrw-00041Z-1E for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Jul 2021 02:44:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7Xrm-00040B-Jj for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 02:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35877) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m7Xrl-0005jq-NL for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 02:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m7Xrl-0008LN-Ml for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 02:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Jul 2021 06:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49722 X-GNU-PR-Package: emacs Original-Received: via spool by 49722-submit@debbugs.gnu.org id=B49722.162719540032017 (code B ref 49722); Sun, 25 Jul 2021 06:44:01 +0000 Original-Received: (at 49722) by debbugs.gnu.org; 25 Jul 2021 06:43:20 +0000 Original-Received: from localhost ([127.0.0.1]:47423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7Xr6-0008KK-IE for submit@debbugs.gnu.org; Sun, 25 Jul 2021 02:43:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7Xr5-0008K6-2u for 49722@debbugs.gnu.org; Sun, 25 Jul 2021 02:43:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60474) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7Xqz-000581-NJ; Sun, 25 Jul 2021 02:43:13 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4905 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7Xqz-0006zb-BU; Sun, 25 Jul 2021 02:43:13 -0400 In-Reply-To: <87o8arz00o.fsf@163.com> (message from Andrei Kuznetsov on Sun, 25 Jul 2021 08:53:59 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210687 Archived-At: > From: Andrei Kuznetsov > Cc: 49722@debbugs.gnu.org > Date: Sun, 25 Jul 2021 08:53:59 +0800 > > Eli Zaretskii writes: > > > Thanks, but please show the error messages you saw before applying > > that patch. > > xftfont.c: In function ‘xftfont_cached_font_ok’: > xftfont.c:591: error: ‘FC_LCD_FILTER’ undeclared (first use in this function) > xftfont.c:591: error: (Each undeclared identifier is reported only once > xftfont.c:591: error: for each function it appears in.) > > It appears that FC_LCD_FILTER is not present on these older versions of > fontconfig. Thanks. We once had the following in xftfont.c: #ifndef FC_LCD_FILTER /* Older fontconfig versions don't have FC_LCD_FILTER. */ #define FC_LCD_FILTER "lcdfilter" #endif But it got moved to ftfont.c when a function which used it was moved there. However, since xftfont.c still uses this, I think we should have this #define in xftfont.c as well, so please try adding that at the beginning of xftfont.c, and see if that helps.