unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 51247@debbugs.gnu.org
Subject: bug#51247: 28.0.60; Insufficient documentation of tab-bar.el internal functions
Date: Mon, 18 Oct 2021 19:53:10 +0300	[thread overview]
Message-ID: <838ryqe0ll.fsf@gnu.org> (raw)
In-Reply-To: <87wnmal1u8.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 18 Oct 2021 19:44:31 +0300)

> From: Juri Linkov <juri@linkov.net>
> Cc: 51247@debbugs.gnu.org
> Date: Mon, 18 Oct 2021 19:44:31 +0300
> 
> >> This text is still wrong:
> >>
> >>   Adding a function to the list causes the tab bar to show
> >>   that string, or display a menu with those menu items when
> >>   you click on the tab bar.
> >>
> >> The tab called "Menu" displays menu items from the global menu-bar,
> >> not from those menu items mentioned in the doc string.
> >> Those menu items are used only to display tabs.
> >
> > Then please point me to a function out of those mentioned in
> > tab-bar-format's :options that returns a list of menu items.  The
> > sentence in the doc string "Every item in the list is a function that
> > returns a string, or a list of menu-item elements, or nil" wasn't
> > mine, it was yours.  What did you have in mind when you wrote that?
> 
> - tab-bar-format-menu-global returns a list of menu items
>   that display the "Menu" tab.  This tab is bound to a command
>   that uses popup-menu to display the global menu on clicking.
> 
> - tab-bar-format-history returns a list of menu items
>   that produce back and forward buttons.
> 
> - tab-bar-format-tabs and tab-bar-format-tabs-groups
>   return a list of menu items that produce the tabs for the tab bar.
> ...
> 
> - Only tab-bar-separator returns a string.

Then the doc string after my changes is exactly right.  I have no idea
what you see that's wrong with it.  You say some functions return menu
items and some return a list of menu items, and that's what the doc
string says.  You say that these values are displayed on the tab bar,
and that's what the doc string says.  So what exactly is wrong??





  reply	other threads:[~2021-10-18 16:53 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-17  8:56 bug#51247: 28.0.60; Insufficient documentation of tab-bar.el internal functions Eli Zaretskii
2021-10-17 17:17 ` Juri Linkov
2021-10-17 18:04   ` Eli Zaretskii
2021-10-17 18:29     ` Juri Linkov
2021-10-17 19:13       ` Eli Zaretskii
2021-10-17 19:27         ` Juri Linkov
2021-10-17 19:38           ` Eli Zaretskii
2021-10-17 19:48             ` Juri Linkov
2021-10-18 11:38               ` Eli Zaretskii
2021-10-18 15:53                 ` Juri Linkov
2021-10-18 16:36                   ` Eli Zaretskii
2021-10-18 16:44                     ` Juri Linkov
2021-10-18 16:53                       ` Eli Zaretskii [this message]
2021-10-18 17:01                         ` Juri Linkov
2021-10-18 17:01                         ` Eli Zaretskii
2021-10-18 17:02                           ` Juri Linkov
2021-10-18 17:15                             ` Eli Zaretskii
2021-10-18 17:21                               ` Juri Linkov
2021-10-18 17:32                                 ` Eli Zaretskii
2021-10-19  6:49                                   ` Juri Linkov
2021-10-19 12:08                                     ` Eli Zaretskii
2021-10-19 19:09                                       ` Juri Linkov
2021-10-20 11:35                                         ` Eli Zaretskii
2021-10-20 16:50                                           ` Juri Linkov
2021-10-21 11:05                                             ` Eli Zaretskii
2021-10-21 16:43                                               ` Juri Linkov
2021-10-21 17:12                                                 ` Eli Zaretskii
2021-10-21 17:27                                                   ` Juri Linkov
2021-10-21 17:41                                                     ` Eli Zaretskii
2021-10-21 17:48                                                       ` Juri Linkov
2021-10-21 18:10                                                         ` Eli Zaretskii
2021-10-18  8:21 ` martin rudalics
2021-10-18 14:14   ` Eli Zaretskii
2021-10-18 17:43     ` martin rudalics
2021-10-18 18:23       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838ryqe0ll.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=51247@debbugs.gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).