From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50752: 28.0.50; easy-menu-define lowers the menu-bar key Date: Wed, 27 Oct 2021 17:00:01 +0300 Message-ID: <838ryewota.fsf@gnu.org> References: <87ee8hfajg.fsf@gnus.org> <838rypc98p.fsf@gnu.org> <87h7ddc8iy.fsf@gnus.org> <831r4hc7ta.fsf@gnu.org> <878rypc7e8.fsf@gnus.org> <83zgr5asej.fsf@gnu.org> <8735oxc51n.fsf@gnus.org> <83wnm8c3v3.fsf@gnu.org> <87tuhcc1u1.fsf@gnus.org> <83tuhcaqad.fsf@gnu.org> <881r4fq5b8.fsf@fencepost.gnu.org> <87tuh5z22g.fsf@gnus.org> <83r1c91bu1.fsf@gnu.org> <878ryhz1cb.fsf@gnus.org> <83o87d1acw.fsf@gnu.org> <87h7d5xl8o.fsf@gnus.org> <83lf2h19cn.fsf@gnu.org> <83ee88ym1q.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11900"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rgm@gnu.org, larsi@gnus.org, 50752@debbugs.gnu.org, shuguang79@qq.com To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 27 16:47:47 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfkDT-0002uK-C9 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Oct 2021 16:47:47 +0200 Original-Received: from localhost ([::1]:47844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mfkDR-0005UI-WD for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Oct 2021 10:47:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42532) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfjUE-00068n-Q1 for bug-gnu-emacs@gnu.org; Wed, 27 Oct 2021 10:01:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38499) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mfjUE-0004rK-2d for bug-gnu-emacs@gnu.org; Wed, 27 Oct 2021 10:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mfjUE-0001Dk-21 for bug-gnu-emacs@gnu.org; Wed, 27 Oct 2021 10:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Oct 2021 14:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50752 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50752-submit@debbugs.gnu.org id=B50752.16353432514039 (code B ref 50752); Wed, 27 Oct 2021 14:01:02 +0000 Original-Received: (at 50752) by debbugs.gnu.org; 27 Oct 2021 14:00:51 +0000 Original-Received: from localhost ([127.0.0.1]:50045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfjU2-00012i-Q2 for submit@debbugs.gnu.org; Wed, 27 Oct 2021 10:00:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfjU0-0000wQ-Qr for 50752@debbugs.gnu.org; Wed, 27 Oct 2021 10:00:49 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37876) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfjTq-0004om-Vc; Wed, 27 Oct 2021 10:00:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VrzsNLmU8iq/ySm+WliWILMUTJHDXxqXKBfLBAD1qRE=; b=OHVXmYgHLJLN QS5szEOQ67e+30M8m+lhsG9/hMBCadxbD7AR1+mY4WUSot3mO+7XmIExtBLoa9v9R5Ky/eKY+PjCp hYb5S3k5vct89KHwoC9SYCn+4qZNX5vIHrpzHU8Pu2PcNfiFqEyhogGzStJYEGOQK9zJMnOg2kc58 KA82r0EF/oa6St2+cugGM+qIRjHbegXF/xxR2o9a4XWXES6Lg7fmsLzbRyDIa6LZzOsHDemTKWTQk vBMZl3G7+5Gf1bbe4GpRURxRNFL9lUZlM0UYDSSLsHiYtqlLssjZjCltbtEFXa6IoCw3luD8XjHxe aRcvjDCMdmOdriKC9xz+JQ==; Original-Received: from [87.69.77.57] (port=2414 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfjTI-0001wL-L3; Wed, 27 Oct 2021 10:00:25 -0400 In-Reply-To: (message from Stefan Kangas on Tue, 26 Oct 2021 22:24:10 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218451 Archived-At: > From: Stefan Kangas > Date: Tue, 26 Oct 2021 22:24:10 +0200 > Cc: larsi@gnus.org, rgm@gnu.org, 50752@debbugs.gnu.org, shuguang79@qq.com > > OK, let me just double check that you mean to memcpy and then just loop > over the memory byte by bite and update them like so: > > int new_ch = XFIXNUM (CHAR_TABLE_REF (Vascii_downcase_table, ch)) > > Or do you mean something even simpler like this? > > if (ch >= 'A' && ch <= 'Z') > new_ch = c + ('A' - 'a'); The latter. > > The log message should say "don't merge to master". > > Hmm. If we can live with a simpler fix on emacs-28, can we not live > with it on master as well? On master, I'd prefer to have the full solution, which you already coded. There's no need to give up a complete solution there. It just is too complex to safely backport it to the release branch, so Emacs 28 will have to do with a 99% solution, not 100%.