From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51821: 29.0.50; Suggest add variable or frame parameter: line-height Date: Fri, 19 Nov 2021 10:04:27 +0200 Message-ID: <838rxkwoz8.fsf@gnu.org> References: <87bl2nhbyp.fsf@163.com> <83bl2nugao.fsf@gnu.org> <878rxq62qt.fsf@gnus.org> <83k0hatxjl.fsf@gnu.org> <875ysu2d18.fsf@gnus.org> <83y25pshaa.fsf@gnu.org> <874k8c8sg0.fsf@gnus.org> <83ilws16hj.fsf@gnu.org> <87wnl8qg8b.fsf@gnus.org> <83czn0123n.fsf@gnu.org> <83v90pwcab.fsf@gnu.org> <87mtm0wrdt.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15059"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, tumashu@163.com, 51821@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 19 09:05:29 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnytk-0003dg-N5 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Nov 2021 09:05:28 +0100 Original-Received: from localhost ([::1]:49650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnyti-0005Tk-EZ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Nov 2021 03:05:26 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnytK-0005TN-SS for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2021 03:05:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54583) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mnytK-0004Gn-Jr for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2021 03:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mnytK-00068I-Am for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2021 03:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Nov 2021 08:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51821 X-GNU-PR-Package: emacs Original-Received: via spool by 51821-submit@debbugs.gnu.org id=B51821.163730907723536 (code B ref 51821); Fri, 19 Nov 2021 08:05:02 +0000 Original-Received: (at 51821) by debbugs.gnu.org; 19 Nov 2021 08:04:37 +0000 Original-Received: from localhost ([127.0.0.1]:37896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnysv-00067Y-96 for submit@debbugs.gnu.org; Fri, 19 Nov 2021 03:04:37 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnyst-00067K-Ip for 51821@debbugs.gnu.org; Fri, 19 Nov 2021 03:04:36 -0500 Original-Received: from [2001:470:142:3::e] (port=54018 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnyso-0004Bo-3k; Fri, 19 Nov 2021 03:04:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pHwydWEoeHskjHfUB8zXBXvNDWT3KpBFUh+6VyVXwT0=; b=YM3UiIP/zj8m VuDaNCgKWGBkxFkr/E2R6rhWL6J7WTaGONjupj+fnDzMqzww4CZqvO7OmAOnyGuENqOUzaXBKRU9N hTJa46EzxwvH9zdFA/7SFdAHLD5asFfWIKMayfr7hLPSGEOHbDiG3PpldhKkq2WOerRsZdUxTZkFO qZe3o6Lm67FFgmDmprRgNqcpWwER7hbKN1TYiT4TWeSgcnxGH1k4rDpJH+GCxG2TAc+4V9u93aZhN ZowMj9LZUVZb5SfKC8eE4iuPQd8JGDFyjv8tx6uJlPrT3fNdRFpEPP0//OoXDA5gq+CC86HmK88Wp TBqRD46V/ZoNnJeg7F6ejw==; Original-Received: from [87.69.77.57] (port=4384 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnysn-0005jz-A2; Fri, 19 Nov 2021 03:04:29 -0500 In-Reply-To: <87mtm0wrdt.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 19 Nov 2021 08:12:30 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220383 Archived-At: > From: Lars Ingebrigtsen > Cc: tumashu@163.com, luangruo@yahoo.com, 51821@debbugs.gnu.org > Date: Fri, 19 Nov 2021 08:12:30 +0100 > > Eli Zaretskii writes: > > > + DEFVAR_LISP ("line-height-factor", Vline_height_factor, > > + doc: /* Factor for enlarging the height of lines that use the default font. > > +The value should be a float number greater than 1. It determines how > > +much will Emacs enlarge the height of a screen line that shows only > > +characters displayed with the default face's font for ASCII characters. > > +This is to avoid differences in height between lines that use the > > +ASCII font and those which use non-ASCII (for example, Chinese) > > +font, which is typically higher than the ASCII one. */); > > Is tying this to the default font the best solution, though? Emacs (by > default) uses at least two fonts -- one monospaced and one that's > proportional, and this will only fix the first issue. No, it should fix both. Did you try that? If you did and it didn't work, can you show a recipe from "emacs -Q" so I could investigate? The "default font" part above is an over-simplification: it is hard to say something accurate enough in a single short sentence. I did try to explain it more in the rest of the doc string: this actually affects any font which some face uses for ASCII characters. > Testing the patch, it also affects the height of faces with :height in > them, meaning that separator lines get much taller than they should be. As I told you, it is currently impossible to single out such faces. Also, I don't think we should necessarily exempt _any_ face that specifies :height, because if that face is used to display with mixed fonts, it will again have the same problem when both CJK fonts and non-CJK fonts are mixed. The separator lines are thus a very special case, and if we want to solve that, we need a more focused solution. For example, we could not stretch the height if the face's height is below some threshold, on the assumption that such small fonts will never used to display human-readable text. But first I want to hear that CJK users are happy with this, and it for now sounds like they aren't :-(