From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#53293: 29.0.50; [PATCH] `eshell-eval-using-options' should report error for unrecognized option, even with no :external Date: Sun, 16 Jan 2022 11:04:29 +0200 Message-ID: <838rvgyrtu.fsf@gnu.org> References: <60740b82-3bea-7fb9-bfc6-617488f656a8@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7662"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53293@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 16 10:05:38 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n91Tm-0001pp-5v for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jan 2022 10:05:38 +0100 Original-Received: from localhost ([::1]:55620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n91Tk-0002BT-JR for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jan 2022 04:05:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41072) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n91TD-0002Aj-27 for bug-gnu-emacs@gnu.org; Sun, 16 Jan 2022 04:05:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49539) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n91TC-0006AS-OT for bug-gnu-emacs@gnu.org; Sun, 16 Jan 2022 04:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n91TC-0000L1-Ac for bug-gnu-emacs@gnu.org; Sun, 16 Jan 2022 04:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jan 2022 09:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53293-submit@debbugs.gnu.org id=B53293.16423238911280 (code B ref 53293); Sun, 16 Jan 2022 09:05:02 +0000 Original-Received: (at 53293) by debbugs.gnu.org; 16 Jan 2022 09:04:51 +0000 Original-Received: from localhost ([127.0.0.1]:42442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n91T1-0000KZ-Kc for submit@debbugs.gnu.org; Sun, 16 Jan 2022 04:04:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n91Sz-0000KM-Kl for 53293@debbugs.gnu.org; Sun, 16 Jan 2022 04:04:50 -0500 Original-Received: from [2001:470:142:3::e] (port=44976 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n91St-00068d-E0; Sun, 16 Jan 2022 04:04:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3fRGMapulYKPDSa32bH9vb9EKjQXtmy1SQ+It60PCuc=; b=oyauapgYQ+sz LP6vhVmVbeWchB77ndD+WfnT0MqTDybllUOYk8zyeUW/DuqtlYqAN7daNpROI94NKzboMSuTSWuob i4m+6brn+Rl58vuTchfAQxML4ZWgdoUDPZc8iHvLBJobC+sngthPaty/F8GS2tDArOQYSGMmdKBOy MZt07pyOEvFNbUZdiyz84lVkgnT77udAbEG+Ygk9iclnvARFC47l09CM6S7WNVytjDaGukHD1pRqd 0v1cGtuLQvLAUn0h3nMBGMmd3NMYgns/aO+r+X4toFfkXgJlbX4CUCTpz9D9FUb/EXk7AvhQpnxYi C1S2i7EwPZtnpSqxC+xvuQ==; Original-Received: from [87.69.77.57] (port=3578 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n91St-0000gP-0N; Sun, 16 Jan 2022 04:04:43 -0500 In-Reply-To: <60740b82-3bea-7fb9-bfc6-617488f656a8@gmail.com> (message from Jim Porter on Sat, 15 Jan 2022 20:03:46 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224369 Archived-At: > From: Jim Porter > Date: Sat, 15 Jan 2022 20:03:46 -0800 > > Despite this incompatibility, I still think this is the right change to > make for all these commands. If a user passes unrecognized options to > any of these, they should be informed of that fact. OTOH, with the current behavior shell scripts that use options not supported by Eshell commands will silently run unaltered, wheres with your change they will error out. Do we care about this?