From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54371: 29.0.50; read-char does not reset idle timer in some cases Date: Fri, 08 Apr 2022 09:50:53 +0300 Message-ID: <838rsgax0y.fsf@gnu.org> References: <83sfrmkvuy.fsf@gnu.org> <87lexduc8w.fsf@gnus.org> <83pmmpls5g.fsf@gnu.org> <83ee35lk8r.fsf@gnu.org> <83sfqw4mvn.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33028"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 54371@debbugs.gnu.org To: Ignacio Casso Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 08 08:52:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nciTo-0008OF-CL for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Apr 2022 08:52:24 +0200 Original-Received: from localhost ([::1]:58334 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nciTm-0001WH-Vs for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Apr 2022 02:52:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37344) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nciSU-0001Vu-9u for bug-gnu-emacs@gnu.org; Fri, 08 Apr 2022 02:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39931) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nciSU-0001AR-1C for bug-gnu-emacs@gnu.org; Fri, 08 Apr 2022 02:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nciST-00089q-SC for bug-gnu-emacs@gnu.org; Fri, 08 Apr 2022 02:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Apr 2022 06:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54371 X-GNU-PR-Package: emacs Original-Received: via spool by 54371-submit@debbugs.gnu.org id=B54371.164940065531344 (code B ref 54371); Fri, 08 Apr 2022 06:51:01 +0000 Original-Received: (at 54371) by debbugs.gnu.org; 8 Apr 2022 06:50:55 +0000 Original-Received: from localhost ([127.0.0.1]:33828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nciSN-00089U-F6 for submit@debbugs.gnu.org; Fri, 08 Apr 2022 02:50:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nciSM-00089G-3l for 54371@debbugs.gnu.org; Fri, 08 Apr 2022 02:50:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59734) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nciSG-00019c-IO; Fri, 08 Apr 2022 02:50:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=R49oTFnLDu7bwAvI/pX/cASl8I1KkQO5OlLP+mq1wIQ=; b=FLLtC9+GB4eD vGQzMbe3JWvt8P/IRAWt/gq/5UQEX9Xz9pXPMEx893Y2JBsLdCqqmFYh5KZVYa9V7wvnd1gsa/8pX f4HQ8+nwplrx2VpSNEZsuV/DM1Zp2xjuHnEgo9WfMKjD5sgaNMsEEkPek8GU5ciOnJORpDbPvw10+ /wmBiDpXLCSK7qLRiq9nO9MofTp7Ad7k6YXQ24QSvfpiT+sdbQvk/ZF5hBH/twrMXtt5a5DfU6ki5 hWIxeCQRgSgiGvOZ/CXMN1KqX2IMoFK7GsMfSHhD0ITUVkfEHyHKak1BeA3UbWcrNyM6ixIFTohId 31hgCYjqawGCIvByJNBsxw==; Original-Received: from [87.69.77.57] (port=2025 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nciSA-0003Xq-EC; Fri, 08 Apr 2022 02:50:46 -0400 In-Reply-To: (message from Ignacio Casso on Thu, 07 Apr 2022 13:42:19 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229552 Archived-At: > From: Ignacio Casso > Cc: larsi@gnus.org, 54371@debbugs.gnu.org > Date: Thu, 07 Apr 2022 13:42:19 +0200 > > > Please send the patch, and let's take it from there. > > > > Thanks. > > Here is a minor patch that adds a footnote to the "Idle Timers" section > of the manual. I have not found any docstrings that need to be updated, > since none of them mention that Emacs becomes idle when it is waiting > for user input. So as far as I know the only place where a user can find > that information is either in the "Idle Timers" section or the "Reading > One Event" section, and the later already mentioned that Emacs becomes idle > only when waiting for input without a timeout. Thanks, I installed this with a small change (@footnote is for stuff that is really minor or off-topic). > I have also one question regarding patches that modify comments, > docstrings, or any other text. What is the best practice, to do M-q > after updating the text, or to try to minimize the number of lines > changed in the patch, as I did now, even if that results in some shorter > or longer lines? It is IMO best not to M-q, because that makes it easier to review the patch. The person who actually installs the patch can then decide whether to M-q before committing. Thanks. P.S. Can we close this bug now?